From: Jakub Kicinski <kuba@kernel.org>
To: Sieng Piaw Liew <liew.s.piaw@gmail.com>
Cc: davem@davemloft.com, edumazet@google.com, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm63xx_enet: reuse skbuff_head
Date: Tue, 14 Jun 2022 21:50:06 -0700 [thread overview]
Message-ID: <20220614215006.67893ec1@kernel.org> (raw)
In-Reply-To: <20220614021009.696-1-liew.s.piaw@gmail.com>
On Tue, 14 Jun 2022 10:10:09 +0800 Sieng Piaw Liew wrote:
> Subject: [PATCH] bcm63xx_enet: reuse skbuff_head
Please improve the subject. One verb and one vaguely correct noun
is not good enough.
> napi_build_skb() reuses NAPI skbuff_head cache in order to save some
> cycles on freeing/allocating skbuff_heads on every new Rx or completed
> Tx.
> Use napi_consume_skb() to feed the cache with skbuff_heads of completed
> Tx so it's never empty.
>
> Signed-off-by: Sieng Piaw Liew <liew.s.piaw@gmail.com>
Please keep Florian's Ack when posting v2.
next prev parent reply other threads:[~2022-06-15 4:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 2:10 [PATCH] bcm63xx_enet: reuse skbuff_head Sieng Piaw Liew
2022-06-14 16:12 ` Florian Fainelli
2022-06-15 4:50 ` Jakub Kicinski [this message]
2022-06-15 6:09 ` [PATCH V2] bcm63xx_enet: switch to napi_build_skb() to reuse skbuff_heads Sieng Piaw Liew
2022-06-15 12:10 ` patchwork-bot+netdevbpf
2022-07-08 8:03 ` [PATCH] bcm63xx: fix Tx cleanup when NAPI poll budget is zero Sieng-Piaw Liew
2022-07-11 20:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614215006.67893ec1@kernel.org \
--to=kuba@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=liew.s.piaw@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.