Re: [PATCHv2 wpan-next 0/2] mac802154: atomic_dec_and_test() fixes

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Alex,

aahringo@redhat.com wrote on Tue, 14 Jun 2022 22:53:19 -0400:

> Hi,
> 
> On Mon, Jun 13, 2022 at 10:15 AM Miquel Raynal
> <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Alex,
> >
> > aahringo@redhat.com wrote on Mon, 13 Jun 2022 00:37:33 -0400:
> >  
> > > Hi,
> > >
> > > I was wondering why nothing worked anymore. I found it...
> > >
> > > changes since v2:
> > >
> > >  - fix fixes tags in mac802154: util: fix release queue handling
> > >  - add patch mac802154: fix atomic_dec_and_test checks got somehow
> > >    confused 2 patch same issue  
> >
> > I've got initially confused with your patchset but yes indeed the API
> > works the opposite way compared to my gut understanding.
> >  
> 
> not the first time I am seeing this, I fixed similar issues already at
> other places.
> 
> btw I told you the right semantic at [0] ....

I focused on the if statement more than the actual syntax...

> 
> > We bought hardware and I am currently setting up a real network to
> > hopefully track these regressions myself in the future.
> >  
> 
> I wonder why you don't use hwsim... and you already mentioned hwsim to
> me.

I do use hwsim but I was exclusively testing the mlme ops with it.

> You can simply make a 6lowpan interface on it and ping it - no
> hardware needed and this would already show issues...

Actually I just learnt about how to create 6lowpan interfaces and do
basic data exchanges, it's rather easy and straightforward, but I must
admit I was not familiar at all with this area and thought it would be
more complex... Indeed, hwsim would work just fine for this purpose,
I will add this to my checklist.

> Now you can say,
> why I do not test it... maybe I do next time but review takes longer
> then.

I'm not saying this at all :) It is my duty, not yours, reviews and
feedback are more than enough.

> 
> - Alex
> 
> [0] https://lore.kernel.org/linux-wpan/CAK-6q+jCYDQ-rtyawz1m2Yt+ti=3d6PrhZebB=-PjcX-6L-Kdg@mail.gmail.com/

Thanks,
Miquèl