From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: "Yuwei Wang" <wangyuweihx@gmail.com>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
roopa@nvidia.com, dsahern@kernel.org, 秦迪 <qindi@staff.weibo.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net, neigh: introduce interval_probe_time for periodic probe
Date: Wed, 15 Jun 2022 16:33:03 -0700 [thread overview]
Message-ID: <20220615163303.11c4e7ef@kernel.org> (raw)
In-Reply-To: <57228F24-81CD-49E9-BE4D-73FC6697872B@blackwall.org>
On Wed, 15 Jun 2022 18:39:53 +0300 Nikolay Aleksandrov wrote:
> >> Do we need the proc entry to be in jiffies when the netlink option is in ms?
> >> Why not make it directly in ms (with _ms similar to other neigh _ms time options) ?
> >>
> >> IMO, it would be better to be consistent with the netlink option which sets it in ms.
> >>
> >> It seems the _ms options were added later and usually people want a more understandable
> >> value, I haven't seen anyone wanting a jiffies version of a ms interval variable. :)
> >>
> >
> >It was in jiffies because this entry was separated from `DELAY_PROBE_TIME`,
> >it keeps nearly all the things the same as `DELAY_PROBE_TIME`,
> >they are both configured by seconds and read to jiffies, was `ms` in
> >netlink attribute,
> >I think it's ok to keep this consistency, and is there a demand
> >required to configure it by ms?
> >If there is that demand, we can make it configured as ms.
>
> no, no demand, just out of user-friendliness :) but
> I get it keeping it as jiffies is also fine
+1 to using ms
next prev parent reply other threads:[~2022-06-15 23:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 10:57 [PATCH net-next v3 0/2] net, neigh: introduce interval_probe_time for periodic probe Yuwei Wang
2022-06-09 10:57 ` [PATCH net-next v3 1/2] sysctl: add proc_dointvec_jiffies_minmax Yuwei Wang
2022-06-14 5:58 ` Jakub Kicinski
2022-06-09 10:57 ` [PATCH net-next v3 2/2] net, neigh: introduce interval_probe_time for periodic probe Yuwei Wang
2022-06-14 6:02 ` Jakub Kicinski
2022-06-15 15:33 ` Yuwei Wang
2022-06-14 9:10 ` Nikolay Aleksandrov
2022-06-15 15:28 ` Yuwei Wang
2022-06-15 15:39 ` Nikolay Aleksandrov
2022-06-15 23:33 ` Jakub Kicinski [this message]
2022-06-18 10:24 ` Yuwei Wang
2022-06-18 10:29 ` Yuwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615163303.11c4e7ef@kernel.org \
--to=kuba@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qindi@staff.weibo.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=wangyuweihx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.