From: Jakub Kicinski <kuba@kernel.org>
To: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, allan.nielsen@microchip.com,
joergen.andreasen@microchip.com, horatiu.vultur@microchip.com,
UNGLinuxDriver@microchip.com, alexandre.belloni@bootlin.com,
fido_max@inbox.ru, alexandru.marginean@nxp.com,
claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
leoyang.li@nxp.com, yangbo.lu@nxp.com
Subject: Re: [net] net: dsa: felix: update base time of time-aware shaper when adjusting PTP time
Date: Wed, 15 Jun 2022 19:58:20 -0700 [thread overview]
Message-ID: <20220615195820.53bae850@kernel.org> (raw)
In-Reply-To: <20220615033610.35983-1-xiaoliang.yang_1@nxp.com>
On Wed, 15 Jun 2022 11:36:10 +0800 Xiaoliang Yang wrote:
> When adjusting the PTP clock, the base time of the TAS configuration
> will become unreliable. We need reset the TAS configuration by using a
> new base time.
>
> For example, if the driver gets a base time 0 of Qbv configuration from
> user, and current time is 20000. The driver will set the TAS base time
> to be 20000. After the PTP clock adjustment, the current time becomes
> 10000. If the TAS base time is still 20000, it will be a future time,
> and TAS entry list will stop running. Another example, if the current
> time becomes to be 10000000 after PTP clock adjust, a large time offset
> can cause the hardware to hang.
>
> This patch introduces a tas_clock_adjust() function to reset the TAS
> module by using a new base time after the PTP clock adjustment. This can
> avoid issues above.
>
> Due to PTP clock adjustment can occur at any time, it may conflict with
> the TAS configuration. We introduce a new TAS lock to serialize the
> access to the TAS registers.
>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
You missed some CCs (./scripts/get_maintainer.pl) and there needs to
be a Fixes tag if you're targeting net.
next prev parent reply other threads:[~2022-06-16 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 3:36 [net] net: dsa: felix: update base time of time-aware shaper when adjusting PTP time Xiaoliang Yang
2022-06-16 2:58 ` Jakub Kicinski [this message]
2022-06-16 4:15 ` 回复: [EXT] " Xiaoliang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615195820.53bae850@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.marginean@nxp.com \
--cc=allan.nielsen@microchip.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=fido_max@inbox.ru \
--cc=horatiu.vultur@microchip.com \
--cc=joergen.andreasen@microchip.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.