fs/coredump.c:399:15: warning: Redundant initialization for 'core_waiters'. The initialized value is overwritten before it is read. [redundantInitialization]

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4193 bytes --]

:::::: 
:::::: Manual check reason: "low confidence static check warning: fs/coredump.c:399:15: warning: Redundant initialization for 'core_waiters'. The initialized value is overwritten before it is read. [redundantInitialization]"
:::::: 

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Eric W. Biederman" <ebiederm@xmission.com>
CC: Kees Cook <keescook@chromium.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   30306f6194cadcc29c77f6ddcd416a75bf5c0232
commit: 0258b5fd7c7124b87e185a1a9322d2c66b1876b7 coredump: Limit coredumps to a single thread group
date:   8 months ago
:::::: branch date: 16 hours ago
:::::: commit date: 8 months ago
compiler: mips-linux-gcc (GCC) 11.3.0
reproduce (cppcheck warning):
        # apt-get install cppcheck
        git checkout 0258b5fd7c7124b87e185a1a9322d2c66b1876b7
        cppcheck --quiet --enable=style,performance,portability --template=gcc FILE

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> fs/coredump.c:399:15: warning: Redundant initialization for 'core_waiters'. The initialized value is overwritten before it is read. [redundantInitialization]
    core_waiters = zap_threads(tsk, core_state, exit_code);
                 ^
   fs/coredump.c:393:19: note: core_waiters is initialized
    int core_waiters = -EBUSY;
                     ^
   fs/coredump.c:399:15: note: core_waiters is overwritten
    core_waiters = zap_threads(tsk, core_state, exit_code);
                 ^

vim +/core_waiters +399 fs/coredump.c

10c28d937e2cca Alex Kelly        2012-09-26  389  
10c28d937e2cca Alex Kelly        2012-09-26  390  static int coredump_wait(int exit_code, struct core_state *core_state)
10c28d937e2cca Alex Kelly        2012-09-26  391  {
10c28d937e2cca Alex Kelly        2012-09-26  392  	struct task_struct *tsk = current;
10c28d937e2cca Alex Kelly        2012-09-26  393  	int core_waiters = -EBUSY;
10c28d937e2cca Alex Kelly        2012-09-26  394  
10c28d937e2cca Alex Kelly        2012-09-26  395  	init_completion(&core_state->startup);
10c28d937e2cca Alex Kelly        2012-09-26  396  	core_state->dumper.task = tsk;
10c28d937e2cca Alex Kelly        2012-09-26  397  	core_state->dumper.next = NULL;
10c28d937e2cca Alex Kelly        2012-09-26  398  
0258b5fd7c7124 Eric W. Biederman 2021-09-22 @399  	core_waiters = zap_threads(tsk, core_state, exit_code);
10c28d937e2cca Alex Kelly        2012-09-26  400  	if (core_waiters > 0) {
10c28d937e2cca Alex Kelly        2012-09-26  401  		struct core_thread *ptr;
10c28d937e2cca Alex Kelly        2012-09-26  402  
70d78fe7c8b640 Andrey Ryabinin   2016-11-10  403  		freezer_do_not_count();
10c28d937e2cca Alex Kelly        2012-09-26  404  		wait_for_completion(&core_state->startup);
70d78fe7c8b640 Andrey Ryabinin   2016-11-10  405  		freezer_count();
10c28d937e2cca Alex Kelly        2012-09-26  406  		/*
10c28d937e2cca Alex Kelly        2012-09-26  407  		 * Wait for all the threads to become inactive, so that
10c28d937e2cca Alex Kelly        2012-09-26  408  		 * all the thread context (extended register state, like
10c28d937e2cca Alex Kelly        2012-09-26  409  		 * fpu etc) gets copied to the memory.
10c28d937e2cca Alex Kelly        2012-09-26  410  		 */
10c28d937e2cca Alex Kelly        2012-09-26  411  		ptr = core_state->dumper.next;
10c28d937e2cca Alex Kelly        2012-09-26  412  		while (ptr != NULL) {
10c28d937e2cca Alex Kelly        2012-09-26  413  			wait_task_inactive(ptr->task, 0);
10c28d937e2cca Alex Kelly        2012-09-26  414  			ptr = ptr->next;
10c28d937e2cca Alex Kelly        2012-09-26  415  		}
10c28d937e2cca Alex Kelly        2012-09-26  416  	}
10c28d937e2cca Alex Kelly        2012-09-26  417  
10c28d937e2cca Alex Kelly        2012-09-26  418  	return core_waiters;
10c28d937e2cca Alex Kelly        2012-09-26  419  }
10c28d937e2cca Alex Kelly        2012-09-26  420  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp