From: Max Staudt <max@enpas.org>
To: Vincent Mailhol <vincent.mailhol@gmail.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters
Date: Fri, 17 Jun 2022 15:37:45 +0200 [thread overview]
Message-ID: <20220617153745.4a3a7a03.max@enpas.org> (raw)
In-Reply-To: <CAMZ6RqLXouCXyt=OGm3GCXdnMJjnycz0BSwM6mcyXtAky_XOdQ@mail.gmail.com>
On Wed, 15 Jun 2022 19:00:10 +0900
Vincent Mailhol <vincent.mailhol@gmail.com> wrote:
> Hi Max,
>
> Because you will have to send a v9 for the split as requested by Marc,
> let me through a last couple of nitpicks.
Perfect, thanks for your help!
> Some of the function or struct names are still prefixed with elm327,
> some other with can327. Could you harmonize everything and use the
> same prefix throughout the file?
This was from back in the elmcan days, where I named the device
specific things according to the device, and the Linux glue according
to the driver. I agree, elm327/can327 is too similar and confusing now.
Done, thanks!
> > +/* Dummy needed to use bitrate_const */
> > +static int can327_do_set_bittiming(struct net_device *netdev)
> > +{
> > + return 0;
> > +}
>
> Seems you forgot to remove that guy :)
> c.f.
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?id=7e193a42c37cf40eba8ac5af2d5e8eeb8b9506f9
Oops m(
I've removed it now, thanks.
Max
prev parent reply other threads:[~2022-06-17 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 15:26 [PATCH v8] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters Max Staudt
2022-06-12 15:56 ` Marc Kleine-Budde
2022-06-15 7:33 ` Marc Kleine-Budde
2022-06-15 10:00 ` Vincent Mailhol
2022-06-17 13:37 ` Max Staudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617153745.4a3a7a03.max@enpas.org \
--to=max@enpas.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=oneukum@suse.com \
--cc=vincent.mailhol@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.