Re: [PATCH 2/2] staging: iio: imu: Add CEVA BNO08x driver

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Thu, 16 Jun 2022 14:30:14 +0200
Jacopo Mondi <jacopo@jmondi.org> wrote:

> Hi Greg
> 
> On Thu, Jun 16, 2022 at 12:57:30PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Jun 16, 2022 at 12:36:34PM +0200, Jacopo Mondi wrote:  
> > > Hi Greg
> > >
> > > On Thu, Jun 16, 2022 at 12:26:18PM +0200, Greg Kroah-Hartman wrote:  
> > > > On Thu, Jun 16, 2022 at 12:00:06PM +0200, Jacopo Mondi wrote:  
> > > > > From: Jacopo Mondi <jacopo@jmondi.org>
> > > > >
> > > > > Add support for CEVA BNO08x Sensor Hub.
> > > > >
> > > > > The BNO08X family (BNO080/85/86) is a System in Package (SiP) that
> > > > > integrates a triaxial accelerometer, triaxial gyroscope, magnetometer
> > > > > and a 32-bit ARM Cortex-M0+ microcontroller running CEVA's SH-2
> > > > > firmware.
> > > > >
> > > > > Datasheet:
> > > > > https://www.ceva-dsp.com/wp-content/uploads/2019/10/BNO080_085-Datasheet.pdf
> > > > >
> > > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > > > > ---
> > > > >  MAINTAINERS                             |   7 +
> > > > >  drivers/staging/iio/Kconfig             |   1 +
> > > > >  drivers/staging/iio/Makefile            |   1 +
> > > > >  drivers/staging/iio/imu/bno08x/Kconfig  |  11 +
> > > > >  drivers/staging/iio/imu/bno08x/Makefile |   3 +
> > > > >  drivers/staging/iio/imu/bno08x/bno08x.c | 618 ++++++++++++++++++++++++  
> > > >
> > > > Why are you adding a new driver to staging/iio/ and not to the real part
> > > > of the kernel?  What needs to be done to it to get it out of here?  
> > >
> > > Mostly because I don't have access to the hw development platform
> > > anymore, and the one I had was not reliable enough for any further
> > > development anyway.
> > >
> > > I went for staging as I cannot guarantee I can test any requested
> > > change on the series.
> > >
> > > I'm afraid this is a "take it or leave it" series, and as the driver
> > > does anyway work (even if for a single feature) I thought it was worth
> > > sending it upstream anyway.  
> >
> > Sure, but staging is not a dumping ground, if you want to submit it and
> > run away, I can't take it here, sorry.
> >
> > Perhaps just let this live as a patch on the mailing list and if anyone
> > else wants to pick it up and maintain it, they can do so.  
> 
> That would be fine with me. Dan already had a comment, let's see if
> Jonathan or others from the IIO subsystem have more and see what to
> do.
>

We can do a superficial review, but I'm thinking the same as Greg - maybe
just living on the mailing list until someone has hardware and can test is
the best plan long term.  Note, one option would be to emulate it. We've done
that for a few bits of hard to setup or hard to acquire hardware where we
want to be able to refactor the code.  Also because it's nice to have CI :)
Vincent's (+CC) Roadtest is great for that though this device may be a bit complex
to easily emulate.

https://lore.kernel.org/all/20220311162445.346685-1-vincent.whitchurch@axis.com/

Jonathan

> Thanks
>    j
> >
> > thanks,
> >
> > greg k-h