All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
	netdev@vger.kernel.org, Taras Chornyi <tchornyi@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org,
	Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
	Yevhen Orlov <yevhen.orlov@plvision.eu>
Subject: Re: [PATCH V2 net-next 4/4] net: marvell: prestera: implement software MDB entries allocation
Date: Fri, 17 Jun 2022 22:01:27 +0800	[thread overview]
Message-ID: <202206172146.gg9GL71Z-lkp@intel.com> (raw)
In-Reply-To: <20220617101520.19794-5-oleksandr.mazur@plvision.eu>

Hi Oleksandr,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Oleksandr-Mazur/net-marvell-prestera-add-MDB-offloading-support/20220617-181737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 982c3e2948d6a30d34f186e3b7d592a33147719b
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220617/202206172146.gg9GL71Z-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/e58f821bf9b04f502947d46edce5e694afba26ca
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Oleksandr-Mazur/net-marvell-prestera-add-MDB-offloading-support/20220617-181737
        git checkout e58f821bf9b04f502947d46edce5e694afba26ca
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/net/ethernet/marvell/prestera/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/prestera/prestera_switchdev.c: In function 'prestera_mdb_flush_bridge_port':
>> drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1776:36: warning: variable 'mdb' set but not used [-Wunused-but-set-variable]
    1776 |         struct prestera_mdb_entry *mdb;
         |                                    ^~~


vim +/mdb +1776 drivers/net/ethernet/marvell/prestera/prestera_switchdev.c

  1769	
  1770	static void
  1771	prestera_mdb_flush_bridge_port(struct prestera_bridge_port *br_port)
  1772	{
  1773		struct prestera_br_mdb_port *br_mdb_port, *tmp_port;
  1774		struct prestera_br_mdb_entry *br_mdb, *br_mdb_tmp;
  1775		struct prestera_bridge *br_dev = br_port->bridge;
> 1776		struct prestera_mdb_entry *mdb;
  1777	
  1778		list_for_each_entry_safe(br_mdb, br_mdb_tmp, &br_dev->br_mdb_entry_list,
  1779					 br_mdb_entry_node) {
  1780			mdb = br_mdb->mdb;
  1781	
  1782			list_for_each_entry_safe(br_mdb_port, tmp_port,
  1783						 &br_mdb->br_mdb_port_list,
  1784						 br_mdb_port_node) {
  1785				prestera_mdb_port_del(br_mdb->mdb,
  1786						      br_mdb_port->br_port->dev);
  1787				prestera_br_mdb_port_del(br_mdb,  br_mdb_port->br_port);
  1788			}
  1789			prestera_br_mdb_entry_put(br_mdb);
  1790		}
  1791	}
  1792	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

      reply	other threads:[~2022-06-17 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 10:15 [PATCH V2 net-next 0/4] net: marvell: prestera: add MDB offloading support Oleksandr Mazur
2022-06-17 10:15 ` [PATCH V2 net-next 1/4] net: marvell: prestera: rework bridge flags setting Oleksandr Mazur
2022-06-17 10:15 ` [PATCH V2 net-next 2/4] net: marvell: prestera: define MDB/flood domain entries and HW API to offload them to the HW Oleksandr Mazur
2022-06-17 10:15 ` [PATCH V2 net-next 3/4] net: marvell: prestera: define and implement MDB / flood domain API for entires creation and deletion Oleksandr Mazur
2022-06-17 10:15 ` [PATCH V2 net-next 4/4] net: marvell: prestera: implement software MDB entries allocation Oleksandr Mazur
2022-06-17 14:01   ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206172146.gg9GL71Z-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr.mazur@plvision.eu \
    --cc=pabeni@redhat.com \
    --cc=tchornyi@marvell.com \
    --cc=yevhen.orlov@plvision.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.