From mboxrd@z Thu Jan 1 00:00:00 1970 From: kernel test robot Date: Fri, 17 Jun 2022 17:06:42 +0000 Subject: Re: [PATCH 1/4] hugetlb: skip to end of PT page mapping when pte not present Message-Id: <202206180021.rcc4B1by-lkp@intel.com> List-Id: References: <20220616210518.125287-2-mike.kravetz@oracle.com> In-Reply-To: <20220616210518.125287-2-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mike Kravetz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: kbuild-all@lists.01.org, Muchun Song , Baolin Wang , Michal Hocko , Peter Xu , Naoya Horiguchi , James Houghton , Mina Almasry , "Aneesh Kumar K . V" , Anshuman Khandual , Paul Walmsley , Christian Borntraeger , catalin.marinas@arm.com, will@kernel.org, Andrew Morton , Mike Kravetz Hi Mike, I love your patch! Yet something to improve: [auto build test ERROR on soc/for-next] [also build test ERROR on linus/master v5.19-rc2 next-20220617] [cannot apply to arm64/for-next/core arm/for-next kvmarm/next xilinx-xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20220618/202206180021.rcc4B1by-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/4c647687607f10fece04967b8180c0dadaf765e6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726 git checkout 4c647687607f10fece04967b8180c0dadaf765e6 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/hugetlb.c: In function 'hugetlb_mask_last_page': >> mm/hugetlb.c:6901:9: error: duplicate case value 6901 | case PUD_SIZE: | ^~~~ mm/hugetlb.c:6899:9: note: previously used here 6899 | case P4D_SIZE: | ^~~~ vim +6901 mm/hugetlb.c 6886 6887 /* 6888 * Return a mask that can be used to update an address to the last huge 6889 * page in a page table page mapping size. Used to skip non-present 6890 * page table entries when linearly scanning address ranges. Architectures 6891 * with unique huge page to page table relationships can define their own 6892 * version of this routine. 6893 */ 6894 unsigned long hugetlb_mask_last_page(struct hstate *h) 6895 { 6896 unsigned long hp_size = huge_page_size(h); 6897 6898 switch (hp_size) { 6899 case P4D_SIZE: 6900 return PGDIR_SIZE - P4D_SIZE; > 6901 case PUD_SIZE: 6902 return P4D_SIZE - PUD_SIZE; 6903 case PMD_SIZE: 6904 return PUD_SIZE - PMD_SIZE; 6905 default: 6906 break; /* Should never happen */ 6907 } 6908 6909 return ~(0UL); 6910 } 6911 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F38C43334 for ; Fri, 17 Jun 2022 17:23:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383010AbiFQRXg (ORCPT ); Fri, 17 Jun 2022 13:23:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382906AbiFQRXe (ORCPT ); Fri, 17 Jun 2022 13:23:34 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADBB918383; Fri, 17 Jun 2022 10:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655486613; x=1687022613; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5r0rapPYszeZBBEbJ/ZlpHIsTYM/ozOqcBVhPIANdrM=; b=eO+bj2hEeWAUudtg5CU9yl9fxz0asyamHWOeYHJ1EqkZMBoywm3DB07O aGX083DvfOXZPN2ZXOmJI1ZgcaGukg1qroBnoGQ44xP2o8WFM+BeCkroY rh4bWzzWk+OKKYO7SlwsYvamyMbMbntL3o0TRfPYlxn71wfwPsUjPs997 VpHzLjF8EJp3GU56yeCLC9Cd98FD81sLzoTPTPSA04zuJncDwl5qnKvvp dDxBqAAkjRdtKVR1jj6BBg4lxGKmo83PxNNP67U5qSyrpa7eiLOlP28Ua zGd05SBQxpAtIZDuL2dJMWgkX3KRRT8yqKE2dqZYhJkiV9k/NWy6nmCbr g==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="259358208" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="259358208" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 10:06:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="560563793" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 17 Jun 2022 10:06:50 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o2FQn-000Pcp-M0; Fri, 17 Jun 2022 17:06:49 +0000 Date: Sat, 18 Jun 2022 01:06:42 +0800 From: kernel test robot To: Mike Kravetz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: kbuild-all@lists.01.org, Muchun Song , Baolin Wang , Michal Hocko , Peter Xu , Naoya Horiguchi , James Houghton , Mina Almasry , "Aneesh Kumar K . V" , Anshuman Khandual , Paul Walmsley , Christian Borntraeger , catalin.marinas@arm.com, will@kernel.org, Andrew Morton , Linux Memory Management List , Mike Kravetz Subject: Re: [PATCH 1/4] hugetlb: skip to end of PT page mapping when pte not present Message-ID: <202206180021.rcc4B1by-lkp@intel.com> References: <20220616210518.125287-2-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616210518.125287-2-mike.kravetz@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Mike, I love your patch! Yet something to improve: [auto build test ERROR on soc/for-next] [also build test ERROR on linus/master v5.19-rc2 next-20220617] [cannot apply to arm64/for-next/core arm/for-next kvmarm/next xilinx-xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20220618/202206180021.rcc4B1by-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/4c647687607f10fece04967b8180c0dadaf765e6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726 git checkout 4c647687607f10fece04967b8180c0dadaf765e6 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/hugetlb.c: In function 'hugetlb_mask_last_page': >> mm/hugetlb.c:6901:9: error: duplicate case value 6901 | case PUD_SIZE: | ^~~~ mm/hugetlb.c:6899:9: note: previously used here 6899 | case P4D_SIZE: | ^~~~ vim +6901 mm/hugetlb.c 6886 6887 /* 6888 * Return a mask that can be used to update an address to the last huge 6889 * page in a page table page mapping size. Used to skip non-present 6890 * page table entries when linearly scanning address ranges. Architectures 6891 * with unique huge page to page table relationships can define their own 6892 * version of this routine. 6893 */ 6894 unsigned long hugetlb_mask_last_page(struct hstate *h) 6895 { 6896 unsigned long hp_size = huge_page_size(h); 6897 6898 switch (hp_size) { 6899 case P4D_SIZE: 6900 return PGDIR_SIZE - P4D_SIZE; > 6901 case PUD_SIZE: 6902 return P4D_SIZE - PUD_SIZE; 6903 case PMD_SIZE: 6904 return PUD_SIZE - PMD_SIZE; 6905 default: 6906 break; /* Should never happen */ 6907 } 6908 6909 return ~(0UL); 6910 } 6911 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD9EDC433EF for ; Fri, 17 Jun 2022 17:29:13 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LPmHX26TWz3cf2 for ; Sat, 18 Jun 2022 03:29:12 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=L5fM3iAs; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=lkp@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=L5fM3iAs; dkim-atps=neutral Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LPmGq1J6Nz30LC for ; Sat, 18 Jun 2022 03:28:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655486915; x=1687022915; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5r0rapPYszeZBBEbJ/ZlpHIsTYM/ozOqcBVhPIANdrM=; b=L5fM3iAsTFlhVd0y0dYAGdyJNOCl6VsgXLCY7CgriNZm8YmCn8RuZUjD GE7jVxj0Pw+kGGd6Ij2yrojt3goVxshMJHeFK9VdwrMEnswE+zAert7sh u7odKHecAB7D9W6YTXFTZoFsqwsw1hvbE+ZpwIkeof8medymwBncCGHmx f9UYEwJFDYoJLS0nln8k2NkuaOQK/vfnWViz0UFD6Wf3wa9Sr6W9Obiqk w9EqCaMFxnp08pgqEMGSAyzLCj3Ld9rXu4ACjlghRkzbP6lrjgMu65Cbt 7be9ox9bBA4jUmTEZDPFhCkbA/+AxPvBMhr9rCe57lLTX4Eqggr/js8lA A==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="278306101" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="278306101" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 10:06:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="560563793" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 17 Jun 2022 10:06:50 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o2FQn-000Pcp-M0; Fri, 17 Jun 2022 17:06:49 +0000 Date: Sat, 18 Jun 2022 01:06:42 +0800 From: kernel test robot To: Mike Kravetz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/4] hugetlb: skip to end of PT page mapping when pte not present Message-ID: <202206180021.rcc4B1by-lkp@intel.com> References: <20220616210518.125287-2-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616210518.125287-2-mike.kravetz@oracle.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mina Almasry , Michal Hocko , kbuild-all@lists.01.org, will@kernel.org, Anshuman Khandual , catalin.marinas@arm.com, Paul Walmsley , Peter Xu , Linux Memory Management List , James Houghton , "Aneesh Kumar K . V" , Baolin Wang , Muchun Song , Andrew Morton , Christian Borntraeger , Naoya Horiguchi , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Mike, I love your patch! Yet something to improve: [auto build test ERROR on soc/for-next] [also build test ERROR on linus/master v5.19-rc2 next-20220617] [cannot apply to arm64/for-next/core arm/for-next kvmarm/next xilinx-xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20220618/202206180021.rcc4B1by-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/4c647687607f10fece04967b8180c0dadaf765e6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726 git checkout 4c647687607f10fece04967b8180c0dadaf765e6 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/hugetlb.c: In function 'hugetlb_mask_last_page': >> mm/hugetlb.c:6901:9: error: duplicate case value 6901 | case PUD_SIZE: | ^~~~ mm/hugetlb.c:6899:9: note: previously used here 6899 | case P4D_SIZE: | ^~~~ vim +6901 mm/hugetlb.c 6886 6887 /* 6888 * Return a mask that can be used to update an address to the last huge 6889 * page in a page table page mapping size. Used to skip non-present 6890 * page table entries when linearly scanning address ranges. Architectures 6891 * with unique huge page to page table relationships can define their own 6892 * version of this routine. 6893 */ 6894 unsigned long hugetlb_mask_last_page(struct hstate *h) 6895 { 6896 unsigned long hp_size = huge_page_size(h); 6897 6898 switch (hp_size) { 6899 case P4D_SIZE: 6900 return PGDIR_SIZE - P4D_SIZE; > 6901 case PUD_SIZE: 6902 return P4D_SIZE - PUD_SIZE; 6903 case PMD_SIZE: 6904 return PUD_SIZE - PMD_SIZE; 6905 default: 6906 break; /* Should never happen */ 6907 } 6908 6909 return ~(0UL); 6910 } 6911 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C124C43334 for ; Fri, 17 Jun 2022 17:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ti/K0i5J6wKu509HagH/WTEtKnnqWCsCcjaYtHwS+fw=; b=fA3KmBcCkqkIT+ cZuzQYe5e0ra1aj/vKmdgmGEDPPbn1eMiEkW0f96dyBmkByyNSDjawwzWe6SFQHJ6bcbzRkgNYqQz yfnRTNZ3GiNIiQSTLqiOaMAH6WwCkdxAuamTwhbe64Ay0IAEpAFye7CWKI50hdP0o26D+ahimL+Rg YbNwKOkbJZVtjJj+jOJFs4kVXI8TUVcYgJ1XLPjnyGA1ww32Dvkgp//+pxOYN7xxkE3ZGOxf4MAoT zaIemq/UEjex7zMfnxHJx2Hg65Q05X4oi2uQUZPEW7ERp9vIMuIgoU4G1g0wSUf0U6K/0pOPfeZWJ F4oCuWS9BjNTZYChKASQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2FmA-008SNb-C6; Fri, 17 Jun 2022 17:28:54 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2Fm6-008SM8-Ue for linux-arm-kernel@lists.infradead.org; Fri, 17 Jun 2022 17:28:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655486930; x=1687022930; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5r0rapPYszeZBBEbJ/ZlpHIsTYM/ozOqcBVhPIANdrM=; b=Lxgu4taTMWjDB6SkpwAGjJiGbMKG6Z7IMy4Eet3rbBhlde6br5VVO5A4 TNiSmCXvttRgCd0X81W426V7jQvFswWLz0Adk8Y/qzJsc19Y50G9kbtsE 8XHt8NrZ6YPLk98nGJV+WbYyZMqNZCufSuExzkiraHjgp+DH0buiKOGC6 zqCuSmJj8dcmPDCpypQ15cpU1SeN6LEfDPR4VnlR9JfWzpCVjqXYji56f XUxPQ9Ybf+8ClhRtD0FWFGibM7hqQp/Zr9dfWxsH5fJaBysbYpEuCYw52 BKVGGEmRxkPDGtgbleHDDxmAav5w9eN9OokxLZrpTcnIfNhmq3z/FHl9z w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="268252238" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="268252238" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 10:06:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="560563793" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 17 Jun 2022 10:06:50 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o2FQn-000Pcp-M0; Fri, 17 Jun 2022 17:06:49 +0000 Date: Sat, 18 Jun 2022 01:06:42 +0800 From: kernel test robot To: Mike Kravetz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: kbuild-all@lists.01.org, Muchun Song , Baolin Wang , Michal Hocko , Peter Xu , Naoya Horiguchi , James Houghton , Mina Almasry , "Aneesh Kumar K . V" , Anshuman Khandual , Paul Walmsley , Christian Borntraeger , catalin.marinas@arm.com, will@kernel.org, Andrew Morton , Linux Memory Management List , Mike Kravetz Subject: Re: [PATCH 1/4] hugetlb: skip to end of PT page mapping when pte not present Message-ID: <202206180021.rcc4B1by-lkp@intel.com> References: <20220616210518.125287-2-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220616210518.125287-2-mike.kravetz@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_102851_070622_06369323 X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike, I love your patch! Yet something to improve: [auto build test ERROR on soc/for-next] [also build test ERROR on linus/master v5.19-rc2 next-20220617] [cannot apply to arm64/for-next/core arm/for-next kvmarm/next xilinx-xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20220618/202206180021.rcc4B1by-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/4c647687607f10fece04967b8180c0dadaf765e6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726 git checkout 4c647687607f10fece04967b8180c0dadaf765e6 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/hugetlb.c: In function 'hugetlb_mask_last_page': >> mm/hugetlb.c:6901:9: error: duplicate case value 6901 | case PUD_SIZE: | ^~~~ mm/hugetlb.c:6899:9: note: previously used here 6899 | case P4D_SIZE: | ^~~~ vim +6901 mm/hugetlb.c 6886 6887 /* 6888 * Return a mask that can be used to update an address to the last huge 6889 * page in a page table page mapping size. Used to skip non-present 6890 * page table entries when linearly scanning address ranges. Architectures 6891 * with unique huge page to page table relationships can define their own 6892 * version of this routine. 6893 */ 6894 unsigned long hugetlb_mask_last_page(struct hstate *h) 6895 { 6896 unsigned long hp_size = huge_page_size(h); 6897 6898 switch (hp_size) { 6899 case P4D_SIZE: 6900 return PGDIR_SIZE - P4D_SIZE; > 6901 case PUD_SIZE: 6902 return P4D_SIZE - PUD_SIZE; 6903 case PMD_SIZE: 6904 return PUD_SIZE - PMD_SIZE; 6905 default: 6906 break; /* Should never happen */ 6907 } 6908 6909 return ~(0UL); 6910 } 6911 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel