From: Pavel Machek <pavel@ucw.cz>
To: Ian Rogers <irogers@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, Yuze Chi <chiyuze@google.com>
Subject: Re: [PATCH] libbpf: Fix is_pow_of_2
Date: Sun, 19 Jun 2022 19:12:48 +0200 [thread overview]
Message-ID: <20220619171248.GC3362@bug> (raw)
In-Reply-To: <20220603041701.2799595-1-irogers@google.com>
Hi!
> From: Yuze Chi <chiyuze@google.com>
>
> +++ b/tools/lib/bpf/libbpf.c
> @@ -4956,7 +4956,7 @@ static void bpf_map__destroy(struct bpf_map *map);
>
> static bool is_pow_of_2(size_t x)
> {
> - return x && (x & (x - 1));
> + return x && !(x & (x - 1));
> }
I'm pretty sure we have this test in macro in includes somewhere... should we use
that instead?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2022-06-19 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 4:17 [PATCH] libbpf: Fix is_pow_of_2 Ian Rogers
2022-06-03 4:31 ` Zvi Effron
2022-06-03 5:33 ` Andrii Nakryiko
2022-06-03 5:35 ` Andrii Nakryiko
2022-06-19 17:12 ` Pavel Machek [this message]
2022-06-21 23:03 ` Zvi Effron
2022-06-22 0:20 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220619171248.GC3362@bug \
--to=pavel@ucw.cz \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chiyuze@google.com \
--cc=daniel@iogearbox.net \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.