All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Heiko Stuebner <heiko@sntech.de>
Cc: palmer@dabbelt.com, paul.walmsley@sifive.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	wefu@redhat.com, guoren@kernel.org, cmuellner@linux.com,
	philipp.tomsich@vrull.eu, hch@lst.de, samuel@sholland.org,
	atishp@atishpatra.org, anup@brainfault.org, mick@ics.forth.gr,
	robh+dt@kernel.org, krzk+dt@kernel.org,
	devicetree@vger.kernel.org, drew@beagleboard.org,
	rdunlap@infradead.org
Subject: Re: [PATCH 1/4] of: also handle dma-noncoherent in of_dma_is_coherent()
Date: Mon, 20 Jun 2022 08:01:27 +0200	[thread overview]
Message-ID: <20220620060127.GA10297@lst.de> (raw)
In-Reply-To: <20220619203212.3604485-2-heiko@sntech.de>

On Sun, Jun 19, 2022 at 10:32:09PM +0200, Heiko Stuebner wrote:
>  bool of_dma_is_coherent(struct device_node *np)
>  {
>  	struct device_node *node;
> +	bool ret = false;

I'd rename this to coherent or is_coherent.

>  
>  	if (IS_ENABLED(CONFIG_OF_DMA_DEFAULT_COHERENT))
> -		return true;
> +		ret = true;

And then do this at initialization time:

	bool is_coherent = IS_ENABLED(CONFIG_OF_DMA_DEFAULT_COHERENT);

but otherwise this looks good to me.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Heiko Stuebner <heiko@sntech.de>
Cc: palmer@dabbelt.com, paul.walmsley@sifive.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	wefu@redhat.com, guoren@kernel.org, cmuellner@linux.com,
	philipp.tomsich@vrull.eu, hch@lst.de, samuel@sholland.org,
	atishp@atishpatra.org, anup@brainfault.org, mick@ics.forth.gr,
	robh+dt@kernel.org, krzk+dt@kernel.org,
	devicetree@vger.kernel.org, drew@beagleboard.org,
	rdunlap@infradead.org
Subject: Re: [PATCH 1/4] of: also handle dma-noncoherent in of_dma_is_coherent()
Date: Mon, 20 Jun 2022 08:01:27 +0200	[thread overview]
Message-ID: <20220620060127.GA10297@lst.de> (raw)
In-Reply-To: <20220619203212.3604485-2-heiko@sntech.de>

On Sun, Jun 19, 2022 at 10:32:09PM +0200, Heiko Stuebner wrote:
>  bool of_dma_is_coherent(struct device_node *np)
>  {
>  	struct device_node *node;
> +	bool ret = false;

I'd rename this to coherent or is_coherent.

>  
>  	if (IS_ENABLED(CONFIG_OF_DMA_DEFAULT_COHERENT))
> -		return true;
> +		ret = true;

And then do this at initialization time:

	bool is_coherent = IS_ENABLED(CONFIG_OF_DMA_DEFAULT_COHERENT);

but otherwise this looks good to me.

  reply	other threads:[~2022-06-20  6:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-19 20:32 [PATCH v4 0/4] riscv: implement Zicbom-based CMO instructions + the t-head variant Heiko Stuebner
2022-06-19 20:32 ` Heiko Stuebner
2022-06-19 20:32 ` [PATCH 1/4] of: also handle dma-noncoherent in of_dma_is_coherent() Heiko Stuebner
2022-06-19 20:32   ` Heiko Stuebner
2022-06-20  6:01   ` Christoph Hellwig [this message]
2022-06-20  6:01     ` Christoph Hellwig
2022-06-20 16:33   ` Atish Patra
2022-06-20 16:33     ` Atish Patra
2022-06-20 18:11     ` Heiko Stuebner
2022-06-20 18:11       ` Heiko Stuebner
2022-06-20 19:41       ` Atish Patra
2022-06-20 19:41         ` Atish Patra
2022-06-19 20:32 ` [PATCH 2/4] dt-bindings: riscv: document cbom-block-size Heiko Stuebner
2022-06-19 20:32   ` Heiko Stuebner
2022-06-19 20:32 ` [PATCH 3/4] riscv: Implement Zicbom-based cache management operations Heiko Stuebner
2022-06-19 20:32   ` Heiko Stuebner
2022-06-20  6:16   ` Christoph Hellwig
2022-06-20  6:16     ` Christoph Hellwig
2022-06-24  7:49     ` Heiko Stuebner
2022-06-24  7:49       ` Heiko Stuebner
2022-06-19 20:32 ` [PATCH 4/4] riscv: implement cache-management errata for T-Head SoCs Heiko Stuebner
2022-06-19 20:32   ` Heiko Stuebner
2022-06-20  0:53   ` kernel test robot
2022-06-29  1:29   ` Samuel Holland
2022-06-29  1:29     ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220620060127.GA10297@lst.de \
    --to=hch@lst.de \
    --cc=anup@brainfault.org \
    --cc=atishp@atishpatra.org \
    --cc=cmuellner@linux.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drew@beagleboard.org \
    --cc=guoren@kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mick@ics.forth.gr \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.