From: Jakub Kicinski <kuba@kernel.org>
To: jdmason@kudzu.us
Cc: patchwork-bot+netdevbpf@kernel.org,
Wentao_Liang <Wentao_Liang_g@163.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c
Date: Mon, 20 Jun 2022 08:56:49 -0700 [thread overview]
Message-ID: <20220620085649.79989775@kernel.org> (raw)
In-Reply-To: <165563641313.16837.10425130041626423819.git-patchwork-notify@kernel.org>
On Sun, 19 Jun 2022 11:00:13 +0000 patchwork-bot+netdevbpf@kernel.org
wrote:
> Hello:
>
> This patch was applied to netdev/net.git (master)
> by David S. Miller <davem@davemloft.net>:
>
> On Sun, 19 Jun 2022 22:14:54 +0800 you wrote:
> > The pointer vdev points to a memory region adjacent to a net_device
> > structure ndev, which is a field of hldev. At line 4740, the invocation
> > to vxge_device_unregister unregisters device hldev, and it also releases
> > the memory region pointed by vdev->bar0. At line 4743, the freed memory
> > region is referenced (i.e., iounmap(vdev->bar0)), resulting in a
> > use-after-free vulnerability. We can fix the bug by calling iounmap
> > before vxge_device_unregister.
> >
> > [...]
>
> Here is the summary with links:
> - drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c
> https://git.kernel.org/netdev/net/c/8fc74d18639a
>
> You are awesome, thank you!
😭😭😭
Jon, if you care about this driver staying upstream please send
a correct fix (on top of this change since it's already merged).
next prev parent reply other threads:[~2022-06-20 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 14:14 [PATCH] drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c Wentao_Liang
2022-06-19 11:00 ` patchwork-bot+netdevbpf
2022-06-20 15:56 ` Jakub Kicinski [this message]
2022-06-20 18:20 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2022-06-19 6:24 wentao_liang_g
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620085649.79989775@kernel.org \
--to=kuba@kernel.org \
--cc=Wentao_Liang_g@163.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.