From: Mel Gorman <mgorman@techsingularity.net>
To: Waiman Long <longman@redhat.com>
Cc: Zhenhua Ma <mazhenhua@xiaomi.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: Lockups due to "locking/rwsem: Make handoff bit handling more consistent"
Date: Mon, 20 Jun 2022 15:09:50 +0100 [thread overview]
Message-ID: <20220620140950.GB15453@techsingularity.net> (raw)
In-Reply-To: <b92bdb56-bfed-9cd2-5eb2-0b96a68b21d8@redhat.com>
On Fri, Jun 17, 2022 at 10:29:20AM -0400, Waiman Long wrote:
> > The C file and shell script to run it are attached.
> >
> Thanks for the reproducer and I will try to reproduce it locally.
>
> It is a known issue that I have receive similar report from an Oracle
> engineer. That is the reason I posted commit 1ee326196c66 ("locking/rwsem:
> Always try to wake waiters in out_nolock path") that was merged in v5.19. I
> believe it helps but it may not be able to eliminate all possible race
> conditions. To make rwsem behave more like before commit d257cc8cb8d5
> ("locking/rwsem: Make handoff bit handling more consistent"), I posted a
> follow-up patch
>
> https://lore.kernel.org/lkml/20220427173124.1428050-1-longman@redhat.com/
>
> But it hasn't gotten review yet.
>
FWIW, the patch passed the test case when applied to both 5.18 and
5.19-rc3.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2022-06-20 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 13:43 Lockups due to "locking/rwsem: Make handoff bit handling more consistent" Mel Gorman
2022-06-17 14:29 ` Waiman Long
2022-06-20 14:09 ` Mel Gorman [this message]
2022-06-22 1:32 ` Waiman Long
2022-06-22 15:09 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620140950.GB15453@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mazhenhua@xiaomi.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.