From: Jakub Kicinski <kuba@kernel.org>
To: Jiang Jian <jiangjian@cdjrlc.com>
Cc: wintera@linux.ibm.com, wenjia@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/net: Fix duplicate 'the' in two places
Date: Tue, 21 Jun 2022 15:32:22 -0700 [thread overview]
Message-ID: <20220621153222.0d328987@kernel.org> (raw)
In-Reply-To: <20220621160756.16226-1-jiangjian@cdjrlc.com>
Please add the version to the patch subject.
This is the second versions, AFAIU so it should have had
[PATCH v2] in the subject line.
On Wed, 22 Jun 2022 00:07:56 +0800 Jiang Jian wrote:
> file: drivers/s390/net/qeth_core_main.c
> line: 3568
> /*
> * there's no outstanding PCI any more, so we
> * have to request a PCI to be sure the the PCI
> * will wake at some time in the future then we
> * can flush packed buffers that might still be
> * hanging around, which can happen if no
> * further send was requested by the stack
> */
> changed to:
> /*
> * there's no outstanding PCI any more, so we
> * have to request a PCI to be sure the PCI
> * will wake at some time in the future. Then we
> * can flush packed buffers that might still be
> * hanging around, which can happen if no
> * further send was requested by the stack
> */
That's basically a copy of the diff, please describe the why and what
not how.
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
> drivers/s390/net/qeth_core_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 9e54fe76a9b2..5248f97ee7a6 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -3565,8 +3565,8 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
> if (!atomic_read(&queue->set_pci_flags_count)) {
> /*
> * there's no outstanding PCI any more, so we
> - * have to request a PCI to be sure the the PCI
> - * will wake at some time in the future then we
> + * have to request a PCI to be sure the PCI
> + * will wake at some time in the future. Then we
You broke the whitespace now.
prev parent reply other threads:[~2022-06-21 22:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 16:07 [PATCH] s390/net: Fix duplicate 'the' in two places Jiang Jian
2022-06-21 22:32 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621153222.0d328987@kernel.org \
--to=kuba@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jiangjian@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.