All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: afd@ti.com
Cc: Ryan Eatmon <reatmon@ti.com>, meta-arago@lists.yoctoproject.org
Subject: Re: [meta-arago][dunfell/master][PATCH] tisdk-bundle: fix prebuilt-images U-Boot binary name for HS
Date: Tue, 21 Jun 2022 11:50:47 -0400	[thread overview]
Message-ID: <20220621155047.GA9834@denix.org> (raw)
In-Reply-To: <20220621153900.27066-1-afd@ti.com>

On Tue, Jun 21, 2022 at 10:39:00AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> HS builds do not generate a -${MACHINE} version of the u-boot.img binary.
> Not sure why we deploy these named this way to begin with, maybe a left-
> over from when we had multiple machines per SDK.. To fix the HS builds
> lets ship the binary named as-is for all platforms.

This could potentially mess up with the way Processor SDK (installer, setup 
scripts, etc.) expects U-boot binary to be called. I.e. the stuff outside of 
CoreSDK and the Yocto build... But I'm not sure, just speculating here.


> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  meta-arago-distro/classes/tisdk-bundle.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/classes/tisdk-bundle.bbclass b/meta-arago-distro/classes/tisdk-bundle.bbclass
> index 7e3f4c26..9e961e1b 100644
> --- a/meta-arago-distro/classes/tisdk-bundle.bbclass
> +++ b/meta-arago-distro/classes/tisdk-bundle.bbclass
> @@ -777,9 +777,9 @@ tisdk_image_build () {
>      fi
>  
>      # Copy the U-Boot image if it exists
> -    if [ -e ${DEPLOY_DIR_IMAGE}/u-boot-${MACHINE}.img ]
> +    if [ -e ${DEPLOY_DIR_IMAGE}/u-boot.img ]
>      then
> -        cp ${DEPLOY_DIR_IMAGE}/u-boot-${MACHINE}.img ${prebuilt_dir}/
> +        cp ${DEPLOY_DIR_IMAGE}/u-boot.img ${prebuilt_dir}/
>      elif [ -e ${DEPLOY_DIR_IMAGE}/u-boot-${MACHINE}.bin ]
>      then
>          cp ${DEPLOY_DIR_IMAGE}/u-boot-${MACHINE}.bin ${prebuilt_dir}/
> -- 
> 2.36.1


  reply	other threads:[~2022-06-21 15:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 15:39 [meta-arago][dunfell/master][PATCH] tisdk-bundle: fix prebuilt-images U-Boot binary name for HS Andrew Davis
2022-06-21 15:50 ` Denys Dmytriyenko [this message]
2022-06-21 16:18   ` Andrew Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220621155047.GA9834@denix.org \
    --to=denis@denix.org \
    --cc=afd@ti.com \
    --cc=meta-arago@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.