From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Brian Masney" <masneyb@onstation.org>,
"David Heidelberg" <david@ixit.cz>,
"Cai Huoqing" <cai.huoqing@linux.dev>,
"Christian Eggers" <ceggers@arri.de>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Eugen Hristev" <eugen.hristev@microchip.com>,
"Gwendal Grignou" <gwendal@chromium.org>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Hui Liu" <hui.liu@mediatek.com>,
"Joe Sandom" <joe.g.sandom@gmail.com>,
"Ismail H . Kose" <ihkose@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Mathieu Othacehe" <m.othacehe@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Parthiban Nallathambi" <pn@denx.de>,
"Philippe Reynes" <tremyfr@yahoo.fr>,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Rishi Gupta" <gupt21@gmail.com>,
"Roan van Dijk" <roan@protonic.nl>,
"Stephen Boyd" <swboyd@chromium.org>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: [PATCH 26/36] iio: light: us5182: Switch from CONFIG_PM guards to pm_ptr() etc
Date: Tue, 21 Jun 2022 21:27:09 +0100 [thread overview]
Message-ID: <20220621202719.13644-27-jic23@kernel.org> (raw)
In-Reply-To: <20220621202719.13644-1-jic23@kernel.org>
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Letting the compiler remove these functions when the kernel is built
without CONFIG_PM support is simpler and less error prone than the
use of #ifdef based config guards.
Removing instances of this approach from IIO also stops them being
copied into new drivers.
Very likely it would be safe to use DEFINE_RUNTIME_DEV_PM_OPS() here,
but that would be a functional change.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/iio/light/us5182d.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
index cbd9978540fa..80d2299da561 100644
--- a/drivers/iio/light/us5182d.c
+++ b/drivers/iio/light/us5182d.c
@@ -922,7 +922,6 @@ static int us5182d_remove(struct i2c_client *client)
return 0;
}
-#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM)
static int us5182d_suspend(struct device *dev)
{
struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@@ -945,11 +944,10 @@ static int us5182d_resume(struct device *dev)
return 0;
}
-#endif
static const struct dev_pm_ops us5182d_pm_ops = {
- SET_SYSTEM_SLEEP_PM_OPS(us5182d_suspend, us5182d_resume)
- SET_RUNTIME_PM_OPS(us5182d_suspend, us5182d_resume, NULL)
+ SYSTEM_SLEEP_PM_OPS(us5182d_suspend, us5182d_resume)
+ RUNTIME_PM_OPS(us5182d_suspend, us5182d_resume, NULL)
};
static const struct acpi_device_id us5182d_acpi_match[] = {
@@ -975,7 +973,7 @@ MODULE_DEVICE_TABLE(of, us5182d_of_match);
static struct i2c_driver us5182d_driver = {
.driver = {
.name = US5182D_DRV_NAME,
- .pm = &us5182d_pm_ops,
+ .pm = pm_ptr(&us5182d_pm_ops),
.of_match_table = us5182d_of_match,
.acpi_match_table = ACPI_PTR(us5182d_acpi_match),
},
--
2.36.1
next prev parent reply other threads:[~2022-06-21 20:21 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 20:26 [PATCH 00/36] IIO: switch easy cases to new simpler PM related macros Jonathan Cameron
2022-06-21 20:26 ` [PATCH 01/36] iio: accel: bma220: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() Jonathan Cameron
2022-06-21 20:26 ` [PATCH 02/36] iio: adc: ad799x: " Jonathan Cameron
2022-06-21 20:26 ` [PATCH 03/36] iio: adc: at91-sam5d2: " Jonathan Cameron
2022-06-21 20:26 ` [PATCH 04/36] iio: adc: imx7d_adc: " Jonathan Cameron
2022-06-22 9:31 ` Bough Chen
2022-06-21 20:26 ` [PATCH 05/36] iio: adc: meson_saradc: " Jonathan Cameron
2022-06-26 22:04 ` Martin Blumenstingl
2022-06-21 20:26 ` [PATCH 06/36] iio: adc: mt6577_auxadc: " Jonathan Cameron
2022-06-21 20:26 ` [PATCH 07/36] iio: adc: stmpe-adc: " Jonathan Cameron
2022-06-21 20:26 ` [PATCH 08/36] iio: adc: ti-am335x: " Jonathan Cameron
2022-06-22 6:29 ` Miquel Raynal
2022-06-21 20:26 ` [PATCH 09/36] iio: adc: xilinx-ams: " Jonathan Cameron
2022-06-21 20:26 ` [PATCH 10/36] iio: chemical: scd4x: " Jonathan Cameron
2022-06-21 20:26 ` [PATCH 11/36] iio: dac: ds4424: " Jonathan Cameron
[not found] ` <CABEhyf8EezacO8hSCDtz8kDnWeTWFJYBz0XJufjmyprv5u3rmw@mail.gmail.com>
2022-06-25 13:08 ` Jonathan Cameron
2022-06-21 20:26 ` [PATCH 12/36] iio: dac: ltc1660: " Jonathan Cameron
2022-06-22 6:25 ` Marcus Folkesson
2022-06-21 20:26 ` [PATCH 13/36] iio: dac: max517: " Jonathan Cameron
2022-06-21 20:26 ` [PATCH 14/36] iio: dac: max5821: " Jonathan Cameron
[not found] ` <CABEhyf-N-hi7z3SQK4FRWyztwJ=3t17NZT-gGCEugQhUkpcZQA@mail.gmail.com>
2022-06-25 13:07 ` Jonathan Cameron
2022-06-21 20:26 ` [PATCH 15/36] iio: dac: mcp4725: " Jonathan Cameron
2022-06-21 20:26 ` [PATCH 16/36] iio: gyro: itg3200: " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 17/36] iio: health: afe4403: " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 18/36] iio: health: afe4404: " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 19/36] iio: light: al3010: " Jonathan Cameron
2022-06-22 9:36 ` David Heidelberg
2022-06-21 20:27 ` [PATCH 20/36] iio: light: al3320a: " Jonathan Cameron
2022-06-25 13:06 ` Jonathan Cameron
2022-06-21 20:27 ` [PATCH 21/36] iio: light: as73211: " Jonathan Cameron
2022-06-23 8:46 ` Christian Eggers
2022-06-21 20:27 ` [PATCH 22/36] iio: light: bh1750: " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 23/36] iio: light: cm3605: " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 24/36] iio: proximity: cros_ec_mkbp: " Jonathan Cameron
2022-06-21 21:06 ` Gwendal Grignou
2022-06-21 20:27 ` [PATCH 25/36] iio: temperature: ltc2983: " Jonathan Cameron
2022-06-23 6:14 ` Sa, Nuno
2022-06-21 20:27 ` Jonathan Cameron [this message]
2022-06-21 20:27 ` [PATCH 27/36] iio: adc: imx8qxp: Switch to DEFINE_RUNTIME_DEV_PM_OPS and pm_ptr() Jonathan Cameron
2022-06-22 9:32 ` Bough Chen
2022-06-21 20:27 ` [PATCH 28/36] iio: light: gp2ap002: " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 29/36] iio: light: isl29028: Use DEFINE_RUNTIME_DEV_PM_OPS() " Jonathan Cameron
2022-06-22 11:09 ` Brian Masney
2022-06-21 20:27 ` [PATCH 30/36] iio: light: tsl2583: Use DEFINE_RUNTIME_DEV_PM_OPS " Jonathan Cameron
2022-06-22 11:10 ` Brian Masney
2022-06-21 20:27 ` [PATCH 31/36] iio: light: tsl2591: Use DEFINE_RUNTIME_DEV_PM_OPS() " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 32/36] iio: light: vcnl4000: Use DEFINE_RUNTIME_DEV_PM_OPS() and pm_ptr() macros Jonathan Cameron
2022-06-21 20:27 ` [PATCH 33/36] iio: light: vcnl4035: " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 34/36] iio: light: veml6030: " Jonathan Cameron
2022-06-26 18:00 ` Rishi Gupta
2022-06-21 20:27 ` [PATCH 35/36] iio: magnetometer: ak8974: " Jonathan Cameron
2022-06-21 20:27 ` [PATCH 36/36] iio: magn: yas530: " Jonathan Cameron
2022-06-27 23:13 ` [PATCH 00/36] IIO: switch easy cases to new simpler PM related macros Paul Cercueil
2022-07-18 17:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621202719.13644-27-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandre.belloni@bootlin.com \
--cc=cai.huoqing@linux.dev \
--cc=ceggers@arri.de \
--cc=david@ixit.cz \
--cc=enric.balletbo@collabora.com \
--cc=eugen.hristev@microchip.com \
--cc=gupt21@gmail.com \
--cc=gwendal@chromium.org \
--cc=haibo.chen@nxp.com \
--cc=hui.liu@mediatek.com \
--cc=ihkose@gmail.com \
--cc=joe.g.sandom@gmail.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=m.othacehe@gmail.com \
--cc=marcus.folkesson@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=masneyb@onstation.org \
--cc=michal.simek@xilinx.com \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=nuno.sa@analog.com \
--cc=paul@crapouillou.net \
--cc=philippe.schenker@toradex.com \
--cc=pn@denx.de \
--cc=roan@protonic.nl \
--cc=swboyd@chromium.org \
--cc=tduszyns@gmail.com \
--cc=tremyfr@yahoo.fr \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.