From: Jakub Kicinski <kuba@kernel.org>
To: Richard Gobert <richardbgobert@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, edumazet@google.com,
willemb@google.com, imagedong@tencent.com, talalahmad@google.com,
kafai@fb.com, vasily.averin@linux.dev, luiz.von.dentz@intel.com,
jk@codeconstruct.com.au, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: helper function for skb_shift
Date: Tue, 21 Jun 2022 22:12:40 -0700 [thread overview]
Message-ID: <20220621221240.36c6a3a6@kernel.org> (raw)
In-Reply-To: <20220620155641.GA3846@debian>
On Mon, 20 Jun 2022 17:56:48 +0200 Richard Gobert wrote:
> Move the len fields manipulation in the skbs to a helper function.
> There is a comment specifically requesting this and there are several
> other areas in the code displaying the same pattern which can be
> refactored.
> This improves code readability.
>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
That's better, thanks. Please move the helper to skbuff.h
and consider changing the subject from talking about skb_shift()
which is just one of the users now to mentioning the helper's name.
next prev parent reply other threads:[~2022-06-22 5:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 15:56 [PATCH v2] net: helper function for skb_shift Richard Gobert
2022-06-22 5:12 ` Jakub Kicinski [this message]
2022-06-22 10:25 ` Richard Gobert
2022-06-22 15:37 ` Jakub Kicinski
2022-06-22 5:14 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621221240.36c6a3a6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=imagedong@tencent.com \
--cc=jk@codeconstruct.com.au \
--cc=kafai@fb.com \
--cc=luiz.von.dentz@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=steffen.klassert@secunet.com \
--cc=talalahmad@google.com \
--cc=vasily.averin@linux.dev \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.