From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/4] btrfs: test read repair on a corrupted compressed extent
Date: Wed, 22 Jun 2022 15:07:45 +0200 [thread overview]
Message-ID: <20220622130745.GA29960@lst.de> (raw)
In-Reply-To: <20220622124118.mkawtc3n2quhi42l@zlang-mailbox>
On Wed, Jun 22, 2022 at 08:41:18PM +0800, Zorro Lang wrote:
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2017 Liu Bo. All Rights Reserved.
> ^^^^^^^^^^^
> Is it a wrong copy&paste ?
A lot of the test is copied from btrfs/141, so I wanted to keep the
copyright intact.
> > +#
> > +# FS QA Test 270
> > +#
> > +# Regression test for btrfs buffered read repair of compressed data.
>
> If this's a regression test, I'd like to see the fix be reviewed/acked
> at first :)
Heh. Actually I'm not sure it is a regression, this was copy and
pasted as well. I think it actually has been broken since day 1.
next prev parent reply other threads:[~2022-06-22 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 4:58 btrfs read repair: more tests Christoph Hellwig
2022-06-22 4:58 ` [PATCH 1/4] btrfs: fix the_btrfs_get_physical invocation in btrfs-map-logical Christoph Hellwig
2022-06-22 4:58 ` [PATCH 2/4] btrfs; add a test for impossible repair cases Christoph Hellwig
2022-06-22 4:58 ` [PATCH 3/4] btrfs: test checker pattern corruption on raid10 Christoph Hellwig
2022-06-22 4:58 ` [PATCH 4/4] btrfs: test read repair on a corrupted compressed extent Christoph Hellwig
2022-06-22 9:21 ` Christoph Hellwig
2022-06-22 12:41 ` Zorro Lang
2022-06-22 13:07 ` Christoph Hellwig [this message]
2022-06-24 2:25 ` Zorro Lang
2022-06-29 14:00 ` btrfs read repair: more tests Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622130745.GA29960@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.