Re: [PATCH v3 2/2] btrfs: Expose the BTRFS commit stats through sysfs

[kernel test robot <lkp@intel.com>]

Hi Ioannis,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.19-rc3]
[also build test ERROR on linus/master]
[cannot apply to kdave/for-next next-20220621]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Ioannis-Angelakopoulos/btrfs-Expose-BTRFS-commit-stats-through-sysfs/20220622-055620
base:    a111daf0c53ae91e71fd2bfe7497862d14132e3e
config: hexagon-randconfig-r045-20220622 (https://download.01.org/0day-ci/archive/20220622/202206221417.F0FRQcFP-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 8b8d126598ce7bd5243da7f94f69fa1104288bee)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/506de693b0d08cfdf4eca94dc0528e9f46071c6e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ioannis-Angelakopoulos/btrfs-Expose-BTRFS-commit-stats-through-sysfs/20220622-055620
        git checkout 506de693b0d08cfdf4eca94dc0528e9f46071c6e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/btrfs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> fs/btrfs/sysfs.c:886:64: error: too few arguments to function call, expected 2, have 1
                   div_u64(fs_info->commit_stats.last_commit_dur / NSEC_PER_MSEC),
                   ~~~~~~~                                                      ^
   include/linux/math64.h:125:19: note: 'div_u64' declared here
   static inline u64 div_u64(u64 dividend, u32 divisor)
                     ^
   fs/btrfs/sysfs.c:887:63: error: too few arguments to function call, expected 2, have 1
                   div_u64(fs_info->commit_stats.max_commit_dur / NSEC_PER_MSEC),
                   ~~~~~~~                                                     ^
   include/linux/math64.h:125:19: note: 'div_u64' declared here
   static inline u64 div_u64(u64 dividend, u32 divisor)
                     ^
   fs/btrfs/sysfs.c:888:65: error: too few arguments to function call, expected 2, have 1
                   div_u64(fs_info->commit_stats.total_commit_dur / NSEC_PER_MSEC));
                   ~~~~~~~                                                       ^
   include/linux/math64.h:125:19: note: 'div_u64' declared here
   static inline u64 div_u64(u64 dividend, u32 divisor)
                     ^
   3 errors generated.


vim +886 fs/btrfs/sysfs.c

   874	
   875	static ssize_t btrfs_commit_stats_show(struct kobject *kobj,
   876					struct kobj_attribute *a, char *buf)
   877	{
   878		struct btrfs_fs_info *fs_info = to_fs_info(kobj);
   879	
   880		return sysfs_emit(buf,
   881			"commits %llu\n"
   882			"last_commit_dur_ms %llu\n"
   883			"max_commit_dur_ms %llu\n"
   884			"total_commit_dur_ms %llu\n",
   885			fs_info->commit_stats.commit_counter,
 > 886			div_u64(fs_info->commit_stats.last_commit_dur / NSEC_PER_MSEC),
   887			div_u64(fs_info->commit_stats.max_commit_dur / NSEC_PER_MSEC),
   888			div_u64(fs_info->commit_stats.total_commit_dur / NSEC_PER_MSEC));
   889	}
   890	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp