From: Stephen Hemminger <stephen@networkplumber.org>
To: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Cc: Huichao Cai <chcchc88@163.com>,
dev@dpdk.org, konstantin.ananyev@intel.com
Subject: Re: [PATCH] ip_frag: replace the rte memcpy with memcpy
Date: Wed, 22 Jun 2022 19:35:20 -0700 [thread overview]
Message-ID: <20220622193520.16e7c2e5@hermes.local> (raw)
In-Reply-To: <ed919af1-e979-009a-4727-e6351ecee55a@yandex.ru>
On Wed, 22 Jun 2022 23:49:39 +0100
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru> wrote:
> > @@ -26,7 +25,7 @@ static inline void __fill_ipv4hdr_frag(struct rte_ipv4_hdr *dst,
> > const struct rte_ipv4_hdr *src, uint16_t header_len,
> > uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)
> > {
> > - rte_memcpy(dst, src, header_len);
> > + memcpy(dst, src, header_len);
>
>
> I am fine with replacements in test and inside the lib, for cases
> where 'len' parameter is constant value.
> Though as I said before, here 'header_len' is not a constant value.
> Are you sure it will not introduce any performance regression?
Do you have any performance tests. The ip header options are very small.
next prev parent reply other threads:[~2022-06-23 2:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 14:09 [PATCH] ip_frag: replace the rte memcpy with memcpy Huichao Cai
2022-06-21 15:11 ` David Marchand
2022-06-22 22:49 ` Konstantin Ananyev
2022-06-23 2:35 ` Stephen Hemminger [this message]
2022-06-23 14:24 ` David Marchand
2022-06-24 17:25 ` Konstantin Ananyev
2022-06-27 11:12 ` Liang Ma
2022-06-23 14:26 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622193520.16e7c2e5@hermes.local \
--to=stephen@networkplumber.org \
--cc=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.