From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
Fidaullah Noonari <fidaullah.noonari@emumba.com>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory
Date: Thu, 23 Jun 2022 00:18:29 +0300 [thread overview]
Message-ID: <20220623001829.754bd504@sovereign> (raw)
In-Reply-To: <CAJFAV8y3eSdFX5SyM6=rw4wazKHmM38xgEd_GbpxbWf2owbP8A@mail.gmail.com>
2022-06-22 19:03 (UTC+0200), David Marchand:
> On Sat, Jun 18, 2022 at 1:29 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> >
> > Hi Fidaullah,
> >
> > Thanks for the fix,
> > Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> This seems backport material.
> Dmitry, Anatoly, do you agree? If so I'll mark it when applying.
>
> As for a Fixes: line, the closer commit touching this part is
> 07dcbfe0101f ("malloc: support multiprocess memory hotplug") but I
> wonder if this bug predates this commit.
I agree and the offending commit seems the right one.
Before that commit the calculation accounted for the header,
with 07dcbfe0101f it was lost:
align = RTE_MAX(align, MALLOC_ELEM_HEADER_LEN);
map_len = RTE_ALIGN_CEIL(align + elt_size + MALLOC_ELEM_TRAILER_LEN,
pg_sz);
next prev parent reply other threads:[~2022-06-22 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 5:18 [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory Fidaullah Noonari
2022-06-16 7:53 ` David Marchand
2022-06-18 11:29 ` Dmitry Kozlyuk
2022-06-22 17:03 ` David Marchand
2022-06-22 21:18 ` Dmitry Kozlyuk [this message]
2022-07-05 5:04 ` Fidaullah Noonari
2022-06-23 7:50 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623001829.754bd504@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fidaullah.noonari@emumba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.