All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: kory.maincent@bootlin.com
Cc: etienne.carriere@linaro.org, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] boot/optee-os: add support for custom tarball URL
Date: Thu, 23 Jun 2022 02:07:57 +0200	[thread overview]
Message-ID: <20220623020757.7852c97c@windsurf> (raw)
In-Reply-To: <20220622083433.1201789-1-kory.maincent@bootlin.com>

Hello,

On Wed, 22 Jun 2022 10:34:33 +0200
kory.maincent@bootlin.com wrote:

> -ifeq ($(BR2_TARGET_OPTEE_OS_CUSTOM_GIT),y)
> +ifeq ($(BR2_TARGET_OPTEE_OS_CUSTOM_TARBALL),y)
> +# Handle custom U-Boot tarballs as specified by the configuration

I followed the discussion on the v1 whether we should test the version
to be "custom" or whether we should test
BR2_TARGET_OPTEE_OS_CUSTOM_TARBALL==y. I initially though there was a
reason for testing version==custom, but I was not able to find why, and
some packages (linux for example) do not test version==custom.

So I agree that testing BR2_TARGET_OPTEE_OS_CUSTOM_TARBALL==y is a
better solution, which is what you have done here.

However, I would ideally like this to be consistent throughout the
tree, which means we should change the following ones:

boot/arm-trusted-firmware/arm-trusted-firmware.mk:ifeq ($(ARM_TRUSTED_FIRMWARE_VERSION),custom)
boot/arm-trusted-firmware/arm-trusted-firmware.mk:ifeq ($(ARM_TRUSTED_FIRMWARE_VERSION),custom)
boot/barebox/barebox.mk:ifeq ($$($(1)_VERSION),custom)
boot/opensbi/opensbi.mk:ifeq ($(OPENSBI_VERSION),custom)
boot/uboot/uboot.mk:ifeq ($(UBOOT_VERSION),custom)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-06-23  0:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  8:34 [Buildroot] [PATCH v2] boot/optee-os: add support for custom tarball URL Kory Maincent via buildroot
2022-06-22 10:29 ` Etienne Carriere
2022-06-22 12:36   ` Köry Maincent via buildroot
2022-06-22 13:00     ` Etienne Carriere
2022-06-23  0:07 ` Thomas Petazzoni via buildroot [this message]
2022-06-23 13:06   ` Köry Maincent via buildroot
2022-06-27 21:24 ` Arnout Vandecappelle
2022-06-29  9:37   ` Etienne Carriere

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220623020757.7852c97c@windsurf \
    --to=buildroot@buildroot.org \
    --cc=etienne.carriere@linaro.org \
    --cc=kory.maincent@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.