From: Jakub Kicinski <kuba@kernel.org>
To: Jiang Jian <jiangjian@cdjrlc.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
idosch@nvidia.com, petrm@nvidia.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlxsw: drop unexpected word 'for' in comments
Date: Thu, 23 Jun 2022 09:22:08 -0700 [thread overview]
Message-ID: <20220623092208.1abbd9dc@kernel.org> (raw)
In-Reply-To: <20220623104601.48149-1-jiangjian@cdjrlc.com>
On Thu, 23 Jun 2022 18:46:01 +0800 Jiang Jian wrote:
> file - drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
> line - 18
>
> * ids for for this purpose in partition definition.
> changed to:
>
> * ids for this purpose in partition definition.
Please stop putting the change into the description.
I think I already complained about this.
This is exactly the same information as is in the patch itself.
And as other people have pointed out - please say that the word
is repeated not "unexpected".
IDK why you made those changes because your patches on Wednesday
where better:
[PATCH] bnxt: Fix typo in comments
Remove the repeated word 'and' from comments
Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
https://lore.kernel.org/r/20220622144526.20659-1-jiangjian@cdjrlc.com/
I'm dropping these patches from you, please redo them:
https://patchwork.kernel.org/project/netdevbpf/patch/20220623104919.49600-1-jiangjian@cdjrlc.com/
https://patchwork.kernel.org/project/netdevbpf/patch/20220622171711.6969-1-jiangjian@cdjrlc.com/
https://patchwork.kernel.org/project/netdevbpf/patch/20220623104601.48149-1-jiangjian@cdjrlc.com/
prev parent reply other threads:[~2022-06-23 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 10:46 [PATCH] mlxsw: drop unexpected word 'for' in comments Jiang Jian
2022-06-23 11:38 ` Ido Schimmel
2022-06-23 16:22 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623092208.1abbd9dc@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiangjian@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.