From: Jakub Kicinski <kuba@kernel.org>
To: Aleksey Shumnik <ashumnik9@gmail.com>
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, xeb@mail.ru
Subject: Re: [PATCH] net/ipv4/ip_gre.c net/ipv6/ip6_gre.c: ip and gre header are recorded twice
Date: Thu, 23 Jun 2022 20:26:02 -0700 [thread overview]
Message-ID: <20220623202602.650ed2e6@kernel.org> (raw)
In-Reply-To: <CAJGXZLiNo=G=5889sPyiCZVjRf65Ygov3=DWFgKmay+Dy3wCYw@mail.gmail.com>
On Thu, 23 Jun 2022 16:51:31 +0300 Aleksey Shumnik wrote:
> > What socket type is the ping you have using?
>
> I use SOCK_DGRAM
Strange.
> > The patch looks strangely mangled, it's white space damaged and refers
> > to a net/inv6 which does not exist.
> >
> > Could you regenerate your changes using git? git commit / format-patch
> > / send-email ?
>
> Thanks a lot for the answer!
> I want to find out, the creation of gre and ip header twice, is it a
> feature or a bug?
I can't think why that'd be a feature. Could add this case to selftests
to show how to repro and catch regressions?
> I did everything according to the instructions, hope everything is
> correct this time.
Nope, still mangled.
next prev parent reply other threads:[~2022-06-24 3:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 13:48 [PATCH] net/ipv4/ip_gre.c net/ipv6/ip6_gre.c: ip and gre header are recorded twice Aleksey Shumnik
2022-06-23 0:19 ` Jakub Kicinski
2022-06-23 13:51 ` Aleksey Shumnik
2022-06-24 3:26 ` Jakub Kicinski [this message]
2022-06-24 13:51 ` Aleksey Shumnik
2022-06-24 17:17 ` Jakub Kicinski
2022-06-28 15:18 ` Aleksey Shumnik
2022-07-02 1:31 ` Jakub Kicinski
2022-07-02 1:42 ` Jakub Kicinski
2022-07-07 16:41 ` Aleksey Shumnik
2022-07-07 23:23 ` Jakub Kicinski
2022-07-28 13:54 ` Aleksey Shumnik
2022-07-28 15:17 ` Jakub Kicinski
2022-07-29 11:56 ` Aleksey Shumnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623202602.650ed2e6@kernel.org \
--to=kuba@kernel.org \
--cc=ashumnik9@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.