From: Yang Weijiang <weijiang.yang@intel.com>
To: pbonzini@redhat.com, seanjc@google.com
Cc: kvm@vger.kernel.org, Yang Weijiang <weijiang.yang@intel.com>
Subject: [PATCH v3 3/3] x86: Check platform vPMU capabilities before run lbr tests
Date: Fri, 24 Jun 2022 05:08:28 -0400 [thread overview]
Message-ID: <20220624090828.62191-4-weijiang.yang@intel.com> (raw)
In-Reply-To: <20220624090828.62191-1-weijiang.yang@intel.com>
Use new helper to check whether pmu is available and Perfmon/Debug
capbilities are supported before read MSR_IA32_PERF_CAPABILITIES to
avoid test failure. The issue can be captured when enable_pmu=0.
Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
---
lib/x86/processor.h | 2 +-
x86/pmu_lbr.c | 32 +++++++++++++-------------------
2 files changed, 14 insertions(+), 20 deletions(-)
diff --git a/lib/x86/processor.h b/lib/x86/processor.h
index 70b9193..bb917b0 100644
--- a/lib/x86/processor.h
+++ b/lib/x86/processor.h
@@ -193,7 +193,7 @@ static inline bool is_intel(void)
#define X86_FEATURE_PAUSEFILTER (CPUID(0x8000000A, 0, EDX, 10))
#define X86_FEATURE_PFTHRESHOLD (CPUID(0x8000000A, 0, EDX, 12))
#define X86_FEATURE_VGIF (CPUID(0x8000000A, 0, EDX, 16))
-
+#define X86_FEATURE_PDCM (CPUID(0x1, 0, ECX, 15))
static inline bool this_cpu_has(u64 feature)
{
diff --git a/x86/pmu_lbr.c b/x86/pmu_lbr.c
index 688634d..497df1e 100644
--- a/x86/pmu_lbr.c
+++ b/x86/pmu_lbr.c
@@ -15,6 +15,7 @@
#define MSR_LBR_SELECT 0x000001c8
volatile int count;
+u32 lbr_from, lbr_to;
static noinline int compute_flag(int i)
{
@@ -38,18 +39,6 @@ static noinline int lbr_test(void)
return 0;
}
-union cpuid10_eax {
- struct {
- unsigned int version_id:8;
- unsigned int num_counters:8;
- unsigned int bit_width:8;
- unsigned int mask_length:8;
- } split;
- unsigned int full;
-} eax;
-
-u32 lbr_from, lbr_to;
-
static void init_lbr(void *index)
{
wrmsr(lbr_from + *(int *) index, 0);
@@ -63,7 +52,7 @@ static bool test_init_lbr_from_exception(u64 index)
int main(int ac, char **av)
{
- struct cpuid id = cpuid(10);
+ u8 version = pmu_version();
u64 perf_cap;
int max, i;
@@ -74,19 +63,24 @@ int main(int ac, char **av)
return 0;
}
- perf_cap = rdmsr(MSR_IA32_PERF_CAPABILITIES);
- eax.full = id.a;
-
- if (!eax.split.version_id) {
+ if (!version) {
printf("No pmu is detected!\n");
return report_summary();
}
+
+ if (!this_cpu_has(X86_FEATURE_PDCM)) {
+ printf("Perfmon/Debug Capabilities MSR isn't supported\n");
+ return report_summary();
+ }
+
+ perf_cap = rdmsr(MSR_IA32_PERF_CAPABILITIES);
+
if (!(perf_cap & PMU_CAP_LBR_FMT)) {
- printf("No LBR is detected!\n");
+ printf("(Architectural) LBR is not supported.\n");
return report_summary();
}
- printf("PMU version: %d\n", eax.split.version_id);
+ printf("PMU version: %d\n", version);
printf("LBR version: %ld\n", perf_cap & PMU_CAP_LBR_FMT);
/* Look for LBR from and to MSRs */
--
2.27.0
next prev parent reply other threads:[~2022-06-24 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 9:08 [kvm-unit-tests PATCH v3 0/3] Fix up test failures due to recent KVM changes Yang Weijiang
2022-06-24 9:08 ` [PATCH v3 1/3] x86: Don't overwrite bits 11 and 12 of MSR_IA32_MISC_ENABLE Yang Weijiang
2022-06-24 9:08 ` [PATCH v3 2/3] x86: Skip perf related tests when platform cannot support Yang Weijiang
2022-06-24 22:08 ` Sean Christopherson
2022-06-25 6:34 ` Yang, Weijiang
2022-06-24 9:08 ` Yang Weijiang [this message]
2022-06-24 22:23 ` [PATCH v3 3/3] x86: Check platform vPMU capabilities before run lbr tests Sean Christopherson
2022-06-25 6:38 ` Yang, Weijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624090828.62191-4-weijiang.yang@intel.com \
--to=weijiang.yang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.