From: Kees Cook <keescook@chromium.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>,
Peter Jones <pjones@redhat.com>, Jeremy Kerr <jk@ozlabs.org>,
Tony Luck <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v3 1/9] pstore: Add priv field to pstore_record for backend specific use
Date: Fri, 24 Jun 2022 10:30:23 -0700 [thread overview]
Message-ID: <202206241029.9C0891C5B6@keescook> (raw)
In-Reply-To: <20220624084925.724516-2-ardb@kernel.org>
On Fri, Jun 24, 2022 at 10:49:17AM +0200, Ard Biesheuvel wrote:
> The EFI pstore backend will need to store per-record variable name data
> when we switch away from the efivars layer. Add a priv field to struct
> pstore_record, and document it as holding a backend specific pointer
> that is assumed to be a kmalloc()d buffer, and will be kfree()d when the
> entire record is freed.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
I'm a fan! This is useful, and I'll likely try to use it for some of the
RAM-specific things too. :)
Acked-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-06-24 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 8:49 [PATCH v3 0/9] efi: Restructure EFI varstore driver Ard Biesheuvel
2022-06-24 8:49 ` [PATCH v3 1/9] pstore: Add priv field to pstore_record for backend specific use Ard Biesheuvel
2022-06-24 17:30 ` Kees Cook [this message]
2022-06-24 8:49 ` [PATCH v3 2/9] efi: vars: Don't drop lock in the middle of efivar_init() Ard Biesheuvel
2022-06-24 8:49 ` [PATCH v3 3/9] efi: vars: Add thin wrapper around EFI get/set variable interface Ard Biesheuvel
2022-06-24 8:49 ` [PATCH v3 4/9] efi: pstore: Omit efivars caching EFI varstore access layer Ard Biesheuvel
2022-06-24 8:49 ` [PATCH v3 5/9] efi: vars: Use locking version to iterate over efivars linked lists Ard Biesheuvel
2022-06-24 8:49 ` [PATCH v3 6/9] efi: vars: Drop __efivar_entry_iter() helper which is no longer used Ard Biesheuvel
2022-06-24 8:49 ` [PATCH v3 7/9] efi: vars: Remove deprecated 'efivars' sysfs interface Ard Biesheuvel
2022-06-24 8:49 ` [PATCH v3 8/9] efi: vars: Switch to new wrapper layer Ard Biesheuvel
2022-06-24 8:49 ` [PATCH v3 9/9] efi: vars: Move efivar caching layer into efivarfs Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202206241029.9C0891C5B6@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mjg59@srcf.ucam.org \
--cc=pjones@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.