From: Jason Gunthorpe <jgg@nvidia.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Li Zhijian <lizhijian@fujitsu.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] RDMA/srp: Fix use-after-free in srp_exit_cmd_priv
Date: Fri, 24 Jun 2022 20:47:57 -0300 [thread overview]
Message-ID: <20220624234757.GD4147@nvidia.com> (raw)
In-Reply-To: <5a4a42fe-c5c8-63fe-365f-e6c74a279cc2@acm.org>
On Fri, Jun 24, 2022 at 04:26:06PM -0700, Bart Van Assche wrote:
> On 6/24/22 15:59, Jason Gunthorpe wrote:
> > I don't even understand how get_device() prevents this call chain??
> >
> > It looks to me like the problem is srp_remove_one() is not waiting for
> > or canceling some outstanding work.
>
> Hi Jason,
>
> My conclusions from the call traces in Li's email are as follows:
> * scsi_host_dev_release() can get called after srp_remove_one().
> * srp_exit_cmd_priv() uses the ib_device pointer. If srp_remove_one() is
> called before srp_exit_cmd_priv() then a use-after-free is triggered.
Shouldn't srp_remove_one() wait for the scsi_host_dev to complete
destruction? Clearly it cannot continue to exist once the IB device
has been removed
> Is calling get_device() and put_device() on the struct ib_device an
> acceptable way to fix this?
As I said, I don't understand at all how this works. get_device() does
not prevent srp_remove_one() from being called.
Jason
next prev parent reply other threads:[~2022-06-24 23:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 4:02 [RFC PATCH] RDMA/srp: Fix use-after-free in srp_exit_cmd_priv Li Zhijian
2022-06-24 22:59 ` Jason Gunthorpe
2022-06-24 23:26 ` Bart Van Assche
2022-06-24 23:47 ` Jason Gunthorpe [this message]
2022-06-24 23:57 ` Bart Van Assche
2022-06-27 6:47 ` lizhijian
2022-06-27 17:28 ` Bart Van Assche
2022-06-28 4:41 ` lizhijian
2022-06-28 21:56 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624234757.GD4147@nvidia.com \
--to=jgg@nvidia.com \
--cc=bvanassche@acm.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.