All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch,
	linux-fbdev@vger.kernel.org
Subject: [PATCH v3 1/4] fbcon: Disallow setting font bigger than screen size
Date: Sun, 26 Jun 2022 00:06:27 +0200	[thread overview]
Message-ID: <20220625220630.333705-2-deller@gmx.de> (raw)
In-Reply-To: <20220625220630.333705-1-deller@gmx.de>

Prevent that users set a font size which is bigger than the physical screen.
It's unlikely this may happen (because screens are usually much larger than the
fonts and each font char is limited to 32x32 pixels), but it may happen on
smaller screens/LCD displays.

Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org # v4.14+
---
 drivers/video/fbdev/core/fbcon.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index c4e91715ef00..e162d5e753e5 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -2469,6 +2469,11 @@ static int fbcon_set_font(struct vc_data *vc, struct console_font *font,
 	if (charcount != 256 && charcount != 512)
 		return -EINVAL;

+	/* font bigger than screen resolution ? */
+	if (font->width  > FBCON_SWAP(info->var.rotate, info->var.xres, info->var.yres) ||
+	    font->height > FBCON_SWAP(info->var.rotate, info->var.yres, info->var.xres))
+		return -EINVAL;
+
 	/* Make sure drawing engine can handle the font */
 	if (!(info->pixmap.blit_x & (1 << (font->width - 1))) ||
 	    !(info->pixmap.blit_y & (1 << (font->height - 1))))
--
2.35.3


  reply	other threads:[~2022-06-25 22:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-25 22:06 [PATCH v3 0/4] fbcon: Fixes for screen resolution changes Helge Deller
2022-06-25 22:06 ` Helge Deller [this message]
2022-06-25 22:06 ` [PATCH v3 2/4] fbcon: Add fbcon_modechange_possible() check Helge Deller
2022-06-25 22:06 ` [PATCH v3 3/4] fbmem: Check screen resolution change against font size Helge Deller
2022-06-25 22:33   ` Daniel Vetter
2022-06-25 22:33     ` Daniel Vetter
2022-06-25 22:37     ` Daniel Vetter
2022-06-25 22:37       ` Daniel Vetter
2022-06-25 23:12       ` Helge Deller
2022-06-25 23:12         ` Helge Deller
2022-06-25 23:56         ` Helge Deller
2022-06-25 23:56           ` Helge Deller
2022-06-26  8:49           ` Daniel Vetter
2022-06-26  8:49             ` Daniel Vetter
2022-06-26  9:00             ` Helge Deller
2022-06-26  9:00               ` Helge Deller
2022-06-25 22:57     ` Helge Deller
2022-06-25 22:57       ` Helge Deller
2022-06-25 22:06 ` [PATCH v3 4/4] fbmem: Prevent invalid virtual screen sizes Helge Deller
2022-06-25 22:34   ` Daniel Vetter
2022-06-25 22:34     ` Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2022-07-06 15:02 [PATCH v3 0/4] fbcon: Fixes for screen resolution changes Helge Deller
2022-07-06 15:02 ` [PATCH v3 1/4] fbcon: Disallow setting font bigger than screen size Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220625220630.333705-2-deller@gmx.de \
    --to=deller@gmx.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.