From: Jakub Kicinski <kuba@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pavel Emelyanov <xemul@openvz.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net] af_unix: Do not call kmemdup() for init_net's sysctl table.
Date: Mon, 27 Jun 2022 10:58:59 -0700 [thread overview]
Message-ID: <20220627105859.3ffec11a@kernel.org> (raw)
In-Reply-To: <871qvbwf2o.fsf@email.froward.int.ebiederm.org>
On Sun, 26 Jun 2022 11:43:27 -0500 Eric W. Biederman wrote:
> Kuniyuki Iwashima <kuniyu@amazon.com> writes:
>
> > While setting up init_net's sysctl table, we need not duplicate the global
> > table and can use it directly.
>
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> I am not quite certain the savings of a single entry table justivies
> the complexity. But the looks correct.
Yeah, the commit message is a little sparse. The "why" is not addressed.
Could you add more details to explain the motivation?
next prev parent reply other threads:[~2022-06-27 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 8:23 [PATCH v2 net] af_unix: Do not call kmemdup() for init_net's sysctl table Kuniyuki Iwashima
2022-06-26 16:43 ` Eric W. Biederman
2022-06-27 17:58 ` Jakub Kicinski [this message]
2022-06-27 18:30 ` Kuniyuki Iwashima
2022-06-27 18:40 ` Eric Dumazet
2022-06-27 18:58 ` Kuniyuki Iwashima
2022-06-27 19:06 ` Eric Dumazet
2022-06-27 19:15 ` Kuniyuki Iwashima
2022-06-27 19:36 ` Eric Dumazet
2022-06-27 19:59 ` Kuniyuki Iwashima
2022-06-27 20:04 ` Eric Dumazet
2022-06-27 20:18 ` Kuniyuki Iwashima
-- strict thread matches above, loose matches on Subject: below --
2022-07-20 6:35 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627105859.3ffec11a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.