From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D898C433EF for ; Mon, 27 Jun 2022 11:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1TN1ipWI6Q/JbLbh5nkC2f8BcZOGTP8yhu2RrolWLDQ=; b=s1CABCbtFDPGdj fLi70H4wzau6cF4tQnZ/2+01ZsTrPyQ4KDkQBSxB6u8pkstrTZ93PoLKMpQscWAjRWbZdDZReHy+8 5GscSJsovyFSsoUb5RpQr7djU1uAfIQiMQTCgKN0maez0uzL+g+i41O+Mw0zuJ4W1PAPwIa3zMn6T aXHHTHv1zz08PPE2da+ToQETA2bnbDzjhw4N3klYsdhIN4VQjo3tewn26QidE1AGTecJbgQy68y6y hULYg0SN2+pRWihE4dZZHCwIV12dcSIenFr2JF7z3Jz8rqFW/nkteOOQKYC6zYD8mWW7hI1sY6Loa lMiol87r2Zpxphxu44aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5nDW-000f3c-FH; Mon, 27 Jun 2022 11:47:46 +0000 Received: from smtp1.axis.com ([195.60.68.17]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5nDS-000ex8-Lh; Mon, 27 Jun 2022 11:47:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1656330463; x=1687866463; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HvYHOeFy99wGwq/w2fx0FEcTo66gkhtePc7lFcpF/fs=; b=Erxpba3u2O0sbgNGRrAk4jmzeSK+h9WhxjUYkj8V+4mpi0CLXgqX2fxa 9U4U8bxzIaxGEe5Away7fGJs9FBuNTZAa3DNdiR/OkIX863vnR6ZjYcVD GrunqnL+qZD1iqSuMGnx4oeqnU6pMdbAAsbFLKpzlOSaVZ3dWoMfGFWB2 HaBVP8hUK6EzzhF2zZVSkxviIAbLYURz+fVxskPs+W8azWXE/55cg9/DQ tTrX4/xHJmfq2rRZMB2tPxIeaURnwS2WzENit/ADujLAPfKmQPbARGTdV fHff9rz1ZPYw1CDR+29ARB4IFOwgT2SLTSYl1tRlNlo1QqmuIU4chQya0 w==; Date: Mon, 27 Jun 2022 13:47:33 +0200 From: Jesper Nilsson To: Serge Semin CC: Rob Herring , Bjorn Helgaas , Lorenzo Pieralisi , Kishon Vijay Abraham I , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Jingoo Han , Krzysztof Kozlowski , Alim Akhtar , Richard Zhu , Lucas Stach , Shawn Guo , "Sascha Hauer" , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Yue Wang , Neil Armstrong , "Kevin Hilman" , Jerome Brunet , "Martin Blumenstingl" , Jonathan Chocron , Thomas Petazzoni , "Jesper Nilsson" , Gustavo Pimentel , Heiko Stuebner , "Paul Walmsley" , Greentime Hu , Rahul Tanwar , Srikanth Thokala , Xiaowei Song , Binghui Wang , Andy Gross , Bjorn Andersson , Stanimir Varbanov , Pratyush Anand , "Thierry Reding" , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Nobuhiro Iwamatsu , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , Manivannan Sadhasivam , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-amlogic@lists.infradead.org" , linux-arm-kernel , "linux-rockchip@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH RESEND v5 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220627114733.GG13332@axis.com> References: <20220624143428.8334-1-Sergey.Semin@baikalelectronics.ru> <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_044743_043723_F189E13A X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, Jun 24, 2022 at 04:34:25PM +0200, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > Reviewed-by: Rob Herring Sorry, I never replied in the thread for the last patch, your reasoning for not changing the parameter name made sense. For the ARTPEC-6 parts, Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B472CCA487 for ; Mon, 27 Jun 2022 11:53:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238621AbiF0Lxl (ORCPT ); Mon, 27 Jun 2022 07:53:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239037AbiF0LxE (ORCPT ); Mon, 27 Jun 2022 07:53:04 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C653DF53; Mon, 27 Jun 2022 04:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1656330456; x=1687866456; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HvYHOeFy99wGwq/w2fx0FEcTo66gkhtePc7lFcpF/fs=; b=YrScMb56OEuqc9o6FhUutnD/8QeywtmPSgdmJVGgOjiGve7Rk4JVR94p OmgEcEZZtvVnYg8H2pm66ekaT1ksGnX3BD5bOVro6njJDTuf4P469THMN nukZ0UD0zMDP+exFbknv/aXk3yp/hLUO3AwzMyfAEDqViKimHRbJFcCqj vTG9e9Z4s3IVfxlIa2PH0qbwNz8C9FPt8SVzBbpx5WW+iY5uHelZJoQr1 D5B6lJizOvq4fYM5wA1G06UvpmU/v3/JPbH/N4iF1nZQpHIShZ2imSQwK 7l6oF+7nq2WGcKczL2gV8rLQzkKmvhes81lHwLspEL7qHaFMYXlnpkkLE g==; Date: Mon, 27 Jun 2022 13:47:33 +0200 From: Jesper Nilsson To: Serge Semin CC: Rob Herring , Bjorn Helgaas , Lorenzo Pieralisi , Kishon Vijay Abraham I , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Jingoo Han , Krzysztof Kozlowski , Alim Akhtar , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Yue Wang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Chocron , Thomas Petazzoni , Jesper Nilsson , Gustavo Pimentel , Heiko Stuebner , Paul Walmsley , Greentime Hu , Rahul Tanwar , Srikanth Thokala , Xiaowei Song , Binghui Wang , Andy Gross , Bjorn Andersson , Stanimir Varbanov , Pratyush Anand , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Nobuhiro Iwamatsu , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , Manivannan Sadhasivam , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-amlogic@lists.infradead.org" , linux-arm-kernel , "linux-rockchip@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH RESEND v5 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220627114733.GG13332@axis.com> References: <20220624143428.8334-1-Sergey.Semin@baikalelectronics.ru> <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 24, 2022 at 04:34:25PM +0200, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > Reviewed-by: Rob Herring Sorry, I never replied in the thread for the last patch, your reasoning for not changing the parameter name made sense. For the ARTPEC-6 parts, Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E82A5C43334 for ; Mon, 27 Jun 2022 11:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0bRVQfirlxIBx466dixLIG1RYe/iP6FpFgKpA1nNuvU=; b=YYywWqhq2qusPT pqhU304L81jkHDLsz68ctk+lOiAagILjWRccghaRZdlcX+s68dehtiPo2o7Djsj/m9U5TmWdrdN5i NSRgN3TQgt2JfE7GcJfybvviiO6HTg5xke/SFqBNSnLDdXWqSoaiYKNJFnoCSx7Ar8BYAhcUEMFu6 AsdnVP3ldu6zh9OQf4FKWXThlSXzF7hYZlEmq51isJ9uAmT4iAY5Fc5oiJTDUIR9lSOBIuBHq61iV Q8w2EFBwNPFVBR968Gxsjb++ZFyVOvTWz3hkyzNaYI0toO9oYMoyBM+7JZ1D/hdzAhbwqUSNGubmq 9D3Q9rMSgmEyHgOtiCvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5nDX-000f3t-8A; Mon, 27 Jun 2022 11:47:47 +0000 Received: from smtp1.axis.com ([195.60.68.17]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5nDS-000ex8-Lh; Mon, 27 Jun 2022 11:47:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1656330463; x=1687866463; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HvYHOeFy99wGwq/w2fx0FEcTo66gkhtePc7lFcpF/fs=; b=Erxpba3u2O0sbgNGRrAk4jmzeSK+h9WhxjUYkj8V+4mpi0CLXgqX2fxa 9U4U8bxzIaxGEe5Away7fGJs9FBuNTZAa3DNdiR/OkIX863vnR6ZjYcVD GrunqnL+qZD1iqSuMGnx4oeqnU6pMdbAAsbFLKpzlOSaVZ3dWoMfGFWB2 HaBVP8hUK6EzzhF2zZVSkxviIAbLYURz+fVxskPs+W8azWXE/55cg9/DQ tTrX4/xHJmfq2rRZMB2tPxIeaURnwS2WzENit/ADujLAPfKmQPbARGTdV fHff9rz1ZPYw1CDR+29ARB4IFOwgT2SLTSYl1tRlNlo1QqmuIU4chQya0 w==; Date: Mon, 27 Jun 2022 13:47:33 +0200 From: Jesper Nilsson To: Serge Semin CC: Rob Herring , Bjorn Helgaas , Lorenzo Pieralisi , Kishon Vijay Abraham I , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Jingoo Han , Krzysztof Kozlowski , Alim Akhtar , Richard Zhu , Lucas Stach , Shawn Guo , "Sascha Hauer" , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Yue Wang , Neil Armstrong , "Kevin Hilman" , Jerome Brunet , "Martin Blumenstingl" , Jonathan Chocron , Thomas Petazzoni , "Jesper Nilsson" , Gustavo Pimentel , Heiko Stuebner , "Paul Walmsley" , Greentime Hu , Rahul Tanwar , Srikanth Thokala , Xiaowei Song , Binghui Wang , Andy Gross , Bjorn Andersson , Stanimir Varbanov , Pratyush Anand , "Thierry Reding" , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Nobuhiro Iwamatsu , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , Manivannan Sadhasivam , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-amlogic@lists.infradead.org" , linux-arm-kernel , "linux-rockchip@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH RESEND v5 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220627114733.GG13332@axis.com> References: <20220624143428.8334-1-Sergey.Semin@baikalelectronics.ru> <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_044743_043723_F189E13A X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Jun 24, 2022 at 04:34:25PM +0200, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > Reviewed-by: Rob Herring Sorry, I never replied in the thread for the last patch, your reasoning for not changing the parameter name made sense. For the ARTPEC-6 parts, Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96BA1C433EF for ; Tue, 28 Jun 2022 00:29:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LX5835gGxz3cCV for ; Tue, 28 Jun 2022 10:29:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=axis.com header.i=@axis.com header.a=rsa-sha256 header.s=axis-central1 header.b=S/iODZvh; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=axis.com (client-ip=195.60.68.17; helo=smtp1.axis.com; envelope-from=jesper.nilsson@axis.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=axis.com header.i=@axis.com header.a=rsa-sha256 header.s=axis-central1 header.b=S/iODZvh; dkim-atps=neutral Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LWmDr1jZBz2xbY for ; Mon, 27 Jun 2022 21:47:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1656330461; x=1687866461; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HvYHOeFy99wGwq/w2fx0FEcTo66gkhtePc7lFcpF/fs=; b=S/iODZvht98C4u69EXSfAaC4sMgtoPaKaoi+UA1oX1vqT1pQjHBJkJL6 DUn5H+vnRjzISY4c9fSw6MQmI1b0fpMlmPKzlSkV7n9iTsNqPPUbTCuEa DVeah8uq6hKHOi3jXRRTbC84h+e6vq0Sz5J5SUOsxSdRJQm0qnz+6MrNZ pfcDroaiRkjyaPQEa6UtJo0rjZHklOm+IbGpHx0hkN/WUd67Kd8dW5e9g qosoaIlLq87YyS61hF30K/4RSeOGzoLfxd0N6fv9Cp+a+1wtCmh4B2pqf LMM5noDpcBJY0tE2aD82R0hx2S/ngDJpzGe/g2iBoG83S5Vlcyl/1S630 A==; Date: Mon, 27 Jun 2022 13:47:33 +0200 From: Jesper Nilsson To: Serge Semin Subject: Re: [PATCH RESEND v5 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220627114733.GG13332@axis.com> References: <20220624143428.8334-1-Sergey.Semin@baikalelectronics.ru> <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Tue, 28 Jun 2022 10:29:05 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Thomas Petazzoni , Kunihiko Hayashi , Neil Armstrong , "linux-pci@vger.kernel.org" , Lorenzo Pieralisi , Binghui Wang , Frank Li , Bjorn Andersson , Minghuan Lian , Thierry Reding , Pavel Parkhomenko , Alim Akhtar , Jonathan Chocron , Nobuhiro Iwamatsu , Jonathan Hunter , Fabio Estevam , Jerome Brunet , Rob Herring , Jesper Nilsson , Lorenzo Pieralisi , Kevin Hilman , Pratyush Anand , "linux-tegra@vger.kernel.org" , linux-arm-kernel , Kishon Vijay Abraham I , "linux-rockchip@lists.infradead.org" , Rahul Tanwar , Andy Gross , NXP Linux Team , Xiaowei Song , Greentime Hu , Richard Zhu , "linux-omap@vger.kernel.org" , Srikanth Thokala , Martin Blumenstingl , "linux-arm-msm@vger.kernel.org" , Sascha Hauer , Manivannan Sadhasivam , Yue Wang , "linux-samsung-soc@vger.kernel.org" , Paul Walmsley , Bjorn Helgaas , "linux-amlogic@lists.infradead.org" , Alexey Malahov , Mingkai Hu , "linux-arm-kernel@lists.infradead.org" , Roy Zang , Jingoo Han , "linuxppc-dev@lists.ozlabs.org" , Heiko Stuebner , "linux-kernel@vger.kernel.org" , Serge Semin , Stanimir Varbanov , Krzysztof Kozlowski , Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jun 24, 2022 at 04:34:25PM +0200, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > Reviewed-by: Rob Herring Sorry, I never replied in the thread for the last patch, your reasoning for not changing the parameter name made sense. For the ARTPEC-6 parts, Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com