From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <snelson@pensando.io>
Cc: Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org, davem@davemloft.net, petrm@nvidia.com,
pabeni@redhat.com, edumazet@google.com, mlxsw@nvidia.com
Subject: Re: [patch net-next 00/11] mlxsw: Implement dev info and dev flash for line cards
Date: Mon, 27 Jun 2022 11:52:09 -0700 [thread overview]
Message-ID: <20220627115209.35b699d9@kernel.org> (raw)
In-Reply-To: <ccd0e04c-5241-16da-929f-18059caee428@pensando.io>
On Mon, 27 Jun 2022 11:38:50 -0700 Shannon Nelson wrote:
> >> Can you encode the base device's PCI info into the auxiliary device's id
> >
> > Would look odd to he PCI BDF in auxdev addsess, wouldn't it?
>
> Sure, it looks a little odd to see something like mycore.app.1281, but
> it does afford the auxiliary driver, and any other observer, a way to
> figure out which device it is representing. This also works nicely when
> trying to associate an auxiliary driver instance for a VF with the
> matching VF PCI driver instance.
I'd personally not mind divorcing devlink from bus devices a little
more. On one hand we have cases like this where there's naturally no
bus device, on the other we have multi-link PCI devices which want to
straddle NUMA nodes but otherwise are just a logical unit.
next prev parent reply other threads:[~2022-06-27 18:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 12:33 [patch net-next 00/11] mlxsw: Implement dev info and dev flash for line cards Jiri Pirko
2022-06-14 12:33 ` [patch net-next 01/11] devlink: introduce nested devlink entity for line card Jiri Pirko
2022-06-15 14:05 ` Ido Schimmel
2022-06-15 17:37 ` Jiri Pirko
2022-06-15 23:37 ` Jakub Kicinski
2022-06-14 12:33 ` [patch net-next 02/11] mlxsw: core_linecards: Introduce per line card auxiliary device Jiri Pirko
2022-06-15 14:52 ` Ido Schimmel
2022-06-15 17:37 ` Jiri Pirko
2022-06-16 7:11 ` Ido Schimmel
2022-06-16 16:39 ` Jiri Pirko
2022-06-16 17:41 ` Ido Schimmel
2022-06-27 8:34 ` Jiri Pirko
2022-06-14 12:33 ` [patch net-next 03/11] mlxsw: core_linecard_dev: Set nested devlink relationship for a line card Jiri Pirko
2022-06-14 12:33 ` [patch net-next 04/11] mlxsw: core_linecards: Expose HW revision and INI version Jiri Pirko
2022-06-14 12:33 ` [patch net-next 05/11] mlxsw: reg: Extend MDDQ by device_info Jiri Pirko
2022-06-14 12:33 ` [patch net-next 06/11] mlxsw: core_linecards: Probe provisioned line cards for devices and expose FW version Jiri Pirko
2022-06-14 12:33 ` [patch net-next 07/11] mlxsw: reg: Add Management DownStream Device Tunneling Register Jiri Pirko
2022-06-14 12:33 ` [patch net-next 08/11] mlxsw: core_linecards: Expose device PSID over device info Jiri Pirko
2022-06-14 12:33 ` [patch net-next 09/11] mlxsw: core_linecards: Implement line card device flashing Jiri Pirko
2022-06-14 12:33 ` [patch net-next 10/11] selftests: mlxsw: Check line card info on provisioned line card Jiri Pirko
2022-06-14 12:33 ` [patch net-next 11/11] selftests: mlxsw: Check line card info on activated " Jiri Pirko
2022-06-15 9:13 ` [patch net-next 00/11] mlxsw: Implement dev info and dev flash for line cards Ido Schimmel
2022-06-15 17:40 ` Jiri Pirko
2022-06-16 7:03 ` Ido Schimmel
2022-06-16 13:11 ` Jiri Pirko
2022-06-16 14:47 ` Ido Schimmel
2022-06-16 16:37 ` Jiri Pirko
2022-06-18 6:12 ` Shannon Nelson
2022-06-27 8:43 ` Jiri Pirko
2022-06-27 18:38 ` Shannon Nelson
2022-06-27 18:52 ` Jakub Kicinski [this message]
2022-06-28 7:06 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627115209.35b699d9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.