All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Reshetova, Elena" <elena.reshetova@intel.com>
Cc: "smatch@vger.kernel.org" <smatch@vger.kernel.org>
Subject: Re: [PATCH] smatch_kernel_host_data: enable additional debug
Date: Mon, 27 Jun 2022 17:39:43 +0300	[thread overview]
Message-ID: <20220627143943.GK11460@kadam> (raw)
In-Reply-To: <DM8PR11MB5750804B3B9315F68FA22E1CE7D19@DM8PR11MB5750.namprd11.prod.outlook.com>

Hey Elena,

I've pushed some changes to smatch_kernel_host_data.c and
smatch_points_to_host_data.c.  It hopefully just brings that code more
in line with the user_data code.

The main thing is that smatch_points_to_host_data.c didn't differentiate
between when the function gets host data from the user vs when it is
passed in.  That means if you have function:

int *frob(int *x)
{
	return x;
}

And one caller passes in host data then all of them get host data back.
So then now we're passing host data pointers to even more functions and
the problem gets worse and worse over time.

Which is maybe not a huge deal in terms of the warnings generated, but
it was taking 8GB of data in my database.

regards,
dan carpenter

  reply	other threads:[~2022-06-27 14:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  8:07 [PATCH] smatch_kernel_host_data: enable additional debug Elena Reshetova
2022-05-18  8:29 ` Dan Carpenter
2022-05-18 10:03   ` Reshetova, Elena
2022-06-27 14:39     ` Dan Carpenter [this message]
2022-06-28  8:27       ` Reshetova, Elena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220627143943.GK11460@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=elena.reshetova@intel.com \
    --cc=smatch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.