From: David Teigland <teigland@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] pvdisplay: support -a option
Date: Mon, 27 Jun 2022 09:54:51 -0500 [thread overview]
Message-ID: <20220627145451.GA30741@redhat.com> (raw)
In-Reply-To: <0f4c62c2-ca98-3fef-b194-6c8a8b2fcd09@huawei.com>
On Sat, Jun 25, 2022 at 10:21:21AM +0800, Wu Guanghao wrote:
> > pvdisplay already supports the -a option, but it is filtered at the begining,
> > so delete the redundant judgment.
> >
> > Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
> > ---
> > tools/pvdisplay.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/pvdisplay.c b/tools/pvdisplay.c
> > index 11f38ebd2..1ed9c0d3f 100644
> > --- a/tools/pvdisplay.c
> > +++ b/tools/pvdisplay.c
> > @@ -72,7 +72,6 @@ int pvdisplay(struct cmd_context *cmd, int argc, char **argv)
> > }
> >
> > if (arg_is_set(cmd, aligned_ARG) ||
> > - arg_is_set(cmd, all_ARG) ||
> > arg_is_set(cmd, binary_ARG) ||
> > arg_is_set(cmd, noheadings_ARG) ||
> > arg_is_set(cmd, options_ARG) ||
You've probably seen that tools/command-lines.in is where we now define
the options accepted by each command. But, many commands still contain
redundant option checking that could be removed. So, nearly all of the
option checks in pvdisplay can be removed, not just -a (and many of the
option combination rules can also be defined in command-lines.h.) If
you'd like to send a larger patch for pvdisplay then we could apply
that instead.
Thanks, Dave
prev parent reply other threads:[~2022-06-27 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 1:47 [PATCH] pvdisplay: support -a option Wu Guanghao
2022-06-25 2:21 ` Wu Guanghao
2022-06-27 14:54 ` David Teigland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627145451.GA30741@redhat.com \
--to=teigland@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.