From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D29FC433EF for ; Tue, 28 Jun 2022 04:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244137AbiF1Et6 (ORCPT ); Tue, 28 Jun 2022 00:49:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244407AbiF1Et5 (ORCPT ); Tue, 28 Jun 2022 00:49:57 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3885013CEF for ; Mon, 27 Jun 2022 21:49:51 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id BFF7568AA6; Tue, 28 Jun 2022 06:49:39 +0200 (CEST) Date: Tue, 28 Jun 2022 06:49:39 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Jaegeuk Kim , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni Subject: Re: [PATCH v3 8/8] nvme: Enable pipelining of zoned writes Message-ID: <20220628044939.GA22504@lst.de> References: <20220627234335.1714393-1-bvanassche@acm.org> <20220627234335.1714393-9-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220627234335.1714393-9-bvanassche@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jun 27, 2022 at 04:43:35PM -0700, Bart Van Assche wrote: > Enabling pipelining for zoned writes. Increase the number of retries > for zoned writes to the maximum number of outstanding commands per hardware > queue. How is this supposed to work? NVMe controllers are completely free to reorder. It also doesn't make sense as all zoned writes in Linux either use zone append or block layer based zone locking.