All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nas Chung <nas.chung@chipsnmedia.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, linux-staging@lists.linux.dev,
	mchehab@kernel.org, Nas Chung <nas.chung@chipsnmedia.com>,
	Robert Beckett <bob.beckett@collabora.com>,
	Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Subject: [PATCH v9 4/6] staging: media: wave5: Add TODO file
Date: Tue, 28 Jun 2022 20:08:19 +0900	[thread overview]
Message-ID: <20220628110821.716-5-nas.chung@chipsnmedia.com> (raw)
In-Reply-To: <20220628110821.716-1-nas.chung@chipsnmedia.com>

Add a TODO file listing all that is need for destaging.

Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
---
 drivers/staging/media/wave5/TODO | 36 ++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 drivers/staging/media/wave5/TODO

diff --git a/drivers/staging/media/wave5/TODO b/drivers/staging/media/wave5/TODO
new file mode 100644
index 000000000000..308954740eb1
--- /dev/null
+++ b/drivers/staging/media/wave5/TODO
@@ -0,0 +1,36 @@
+* Handle interrupts better
+
+Currently the interrupt handling uses an unusual design employing a kfifo to
+transfer irq status to irq thread. This was done as a work around for dropped
+interrupts seen with IRQF_ONESHOT based handling.
+
+This needs further investigation and fixing properly, with the aid of
+C&M and StarFive engineers.
+
+* appropriate error handling:
+allocation failure, mutex acquire failure etc.
+
+* remove all unused struct fields
+
+* change struct fields to 'bool' type or bitfield when appropriate
+Likely good candidates are fields named '*_enable' , '*_on'
+
+* handle vdi_allocate_dma_memory failure , each function has to clean after itself
+
+* make sure that 'u32', 's32' etc. are only used when reading/writing hw
+and change s32 to u32 when s32 is not required
+
+* power management handling - add (runtime_)suspen/resume cb where the clock is enabled
+
+* fix checkpatch issues (mostly fixes , only left to fix MACRO_ARG_REUSE, LONG_LINE)
+
+* revise logic of wave5_vpu_(dec/enc)_register_framebuffer
+
+* check if the  normal kernel endianness/__swab32 routines are sufficient. (instead of the ones
+implemented in the driver
+
+* Extended Codec Controls for encoder.
+
+implement extended codec control for HEVC/H264 encoder.
+PROFILE/LEVEL/MIN_QP/MAX_QP/LOOP_FILTER/HFLIP/VFIIP/ROTATE/
+GOP_SIZE/RC_ENABLE/I_PERIOD/BITRATE.
-- 
2.30.2


  parent reply	other threads:[~2022-06-28 11:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28 11:08 [PATCH v9 0/6] staging: media: wave5: add wave5 codec driver Nas Chung
2022-06-28 11:08 ` [PATCH v9 1/6] staging: media: wave5: Add vpuapi layer Nas Chung
2022-06-28 11:08 ` [PATCH v9 2/6] staging: media: wave5: Add the vdi layer Nas Chung
2022-06-29 16:58   ` Ezequiel Garcia
2022-06-28 11:08 ` [PATCH v9 3/6] staging: media: wave5: Add the v4l2 layer Nas Chung
2022-06-28 11:08 ` Nas Chung [this message]
2022-06-28 11:08 ` [PATCH v9 5/6] dt-bindings: media: staging: wave5: add yaml devicetree bindings Nas Chung
2022-06-28 11:08 ` [PATCH v9 6/6] media: wave5: Add wave5 driver to maintainers file Nas Chung
2022-06-29 15:36 ` [PATCH v9 0/6] staging: media: wave5: add wave5 codec driver Hans Verkuil
2022-06-30 11:22   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628110821.716-5-nas.chung@chipsnmedia.com \
    --to=nas.chung@chipsnmedia.com \
    --cc=bob.beckett@collabora.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.