From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC1C8C43334 for ; Tue, 28 Jun 2022 13:44:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9FF2C83A31; Tue, 28 Jun 2022 15:42:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="emunfOB9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4EDEA8209F; Tue, 28 Jun 2022 15:42:30 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D7A7683A31 for ; Tue, 28 Jun 2022 15:42:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id k20so9616063qkj.1 for ; Tue, 28 Jun 2022 06:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e3xQ85WMgwB6ATVkXzw3R2O4LSO3GpMFnkKkxxQHpbU=; b=emunfOB9UjmFHrckBVe/VgtOW/fDwqCIq+jYza7FkjlUjA4HG80QALXUr4yn9fbs+8 1VD19gT837+gDm+NZ6tD21xSUDBS5IgPLbx/X8L3SQK/uySmyJyCd0tRQSR9EMEOaL8t YhOEEbyFAHvhg/JFwVr9129HJTt4UAKeoVEbk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e3xQ85WMgwB6ATVkXzw3R2O4LSO3GpMFnkKkxxQHpbU=; b=4V98Fn2dJxBhbOSYiegQ45umVxla1i8vgB3MwdhjzPngzQzp2ZjAxvFx1KXAwjhQJR j1zqwAwWN0msTT3DrsAhRoBffVm2I52hbpR73pt7GVImkGuvZD/VUm/zP6L/XzDhTC/i tQFpzY4OfsoY8csiPiielH87BNHEZH1p/7gE/CzhgeJpo3sKXaDII2TxE/I9whTkAjLV YxuLuEDoX9/WYXXmO1G9fwangS/UdtSQtSfaCg2aDMWhj808af+/zISQQJfO/R9+j4A9 UDuLa4uVyVuDSXCMWMLMI2kJMoKFL2OZgMFiNwq9yZ/58SrwN95FqNDzaijUGKSIJI3g fabA== X-Gm-Message-State: AJIora9Js5NqrutsTqGWpoN5fnktHSYaHDv5lLEdSJrCYek30/UtPgYB R1hn4cXhGF0/KU412AJlJqz9mg== X-Google-Smtp-Source: AGRyM1tTmyReeLWwbuXexeGyxvaPk3JgF+6UGg3S4+sce6Hc3rud5RBXAqcuoLhuWNlXx//OzqnQmw== X-Received: by 2002:a05:620a:40c5:b0:6af:4ef7:715f with SMTP id g5-20020a05620a40c500b006af4ef7715fmr2722393qko.767.1656423746540; Tue, 28 Jun 2022 06:42:26 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id 93-20020aed3166000000b00304df6f73f0sm8942637qtg.0.2022.06.28.06.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 06:42:25 -0700 (PDT) Date: Tue, 28 Jun 2022 09:42:23 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: "Priyanka Jain (OSS)" , "Peng Fan (OSS)" , Qiang Zhao , Shengzhou Liu , Alexander Graf , Bin Meng , Wolfgang Denk , Sinan Akman , u-boot@lists.denx.de Subject: Re: [PATCH v3] powerpc: mpc85xx: Set TEXT_BASE addresses to real base values Message-ID: <20220628134223.GH1146598@bill-the-cat> References: <4fea4901-2d25-b867-617b-e03c152cffce@oss.nxp.com> <20220616121944.7841-1-pali@kernel.org> <20220623112910.jotuwvm5ze4rimfh@pali> <20220623123458.GZ2484912@bill-the-cat> <20220628091834.fztja3bcyxvjz4k5@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uAgJxtfIS94j9H4T" Content-Disposition: inline In-Reply-To: <20220628091834.fztja3bcyxvjz4k5@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --uAgJxtfIS94j9H4T Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2022 at 11:18:34AM +0200, Pali Roh=E1r wrote: > On Thursday 23 June 2022 08:34:58 Tom Rini wrote: > > On Thu, Jun 23, 2022 at 01:29:10PM +0200, Pali Roh=E1r wrote: > > > On Thursday 16 June 2022 14:19:44 Pali Roh=E1r wrote: > > > > Currently CONFIG_SPL_TEXT_BASE and CONFIG_SYS_TEXT_BASE addresses a= re > > > > manually increased by 0x1000 due to .bootpg section. This section h= as size > > > > of 0x1000 bytes and is manually put by linker script before .text s= ection > > > > (and therefore before base address) when CONFIG_SYS_MPC85XX_NO_RESE= TVEC is > > > > set. Due to this fact lot of other config options are manually incr= eased by > > > > 0x1000 value to make correct layout. Note that entry point is not on > > > > CONFIG_SPL_TEXT_BASE (image+0x1000) but it is really on address > > > > CONFIG_SPL_TEXT_BASE-0x1000 (means at the start of the image). > > > >=20 > > > > Cleanup handling of .bootpg section when CONFIG_SYS_MPC85XX_NO_RESE= TVEC is > > > > set. Put .bootpg code directly into .text section and move text base > > > > address to the start of .bootpg code. And finally remove +0x1000 va= lue from > > > > lot of config options. With this removal custom PHDRS is not used a= nymore, > > > > so remove it too. > > > >=20 > > > > After this change entry point would be at CONFIG_SPL_TEXT_BASE and = not at > > > > address -0x1000 anymore. > > > >=20 > > > > Tested on P2020 board with SPL and proper U-Boot. > > > >=20 > > > > Signed-off-by: Pali Roh=E1r > > > > --- > > >=20 > > > PING??? > > >=20 > >=20 > > Yes, I thought this was part of fsl-qoriq-2022-6-20-v2 but I see it is > > not. I really don't want to see this have problems to apply, again. > > But it probably will if it's not picked up pretty much now. Peng, > > should I grab this for next? Otherwise someone is going to need to grab > > this, edit and recountdiff it for it to apply as it's really not fair to > > ask Pali to rebase it yet again if it doesn't and git also doesn't > > handle it on a rebase. >=20 > Hm... So how to process this? It's already not applying cleanly, so I've re-applied it and I'm putting it through CI (along with some aspeed fixes) right now. It should end up in next later today. --=20 Tom --uAgJxtfIS94j9H4T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmK7BTkACgkQFHw5/5Y0 tyxtZwv8C+54kG3S+1TJogVr8ie+drNc6AFV2kqqV6FythT55wkACZ8mzAjeRJNx Sauxx+YkaOJOhpwg5ZmOZVeoi5PCO4LFX/k5HX8yq+hohVtdHF/g6aycpn9rMaZ3 ZPl2jVSUBnbuG1Ms0HyAHMO3N/n7t1MGokfhXjgXUk784zO/fXaqb3OJ3SSvwLPa EAUyMmJiksiCz+Z+DS5nJguKrT3/6lzVqwtVCo57TmuGoL94Jdcrl8WOdemGqeNk DEhUSEQF2SStr57mpfGQf2i45+c40I47EGdq3VpMan47abnbL4s02Mn+B05lepaa 8HhTEYYD53TiP668oD62BpKZ7PUTH1aBqxqEmRUlLRaUSyjqv48wSeYmIG4hQyhv 6Um4KC1b/KxNB665UFqMvK5i2US0Wxidw3mTZX/xuHBsOevG1OZh+DIEVzxiO5oB YHpUjC1Sh9yZT6mzyGQgLzFGOeTksy8r7Q/pJk1LmeotS1X284yatMH170VR3jsI +2WQ9QPt =t1YP -----END PGP SIGNATURE----- --uAgJxtfIS94j9H4T--