From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74381C43334 for ; Tue, 28 Jun 2022 18:17:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1E7BF842DF; Tue, 28 Jun 2022 20:17:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FzEgFser"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 90A9D842DF; Tue, 28 Jun 2022 20:17:49 +0200 (CEST) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C57208407A for ; Tue, 28 Jun 2022 20:17:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72d.google.com with SMTP id f14so10432590qkm.0 for ; Tue, 28 Jun 2022 11:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tcyO6Rxps6OniTZQW5Okchz4oIRX5z8zxSZOdhujk4k=; b=FzEgFser8GsItHjXnSVeN0znrn1q2LCJ5gd80ZUcYlxABx/DaCyeGIpvb46OFHk8SU III/o7NQRysZ4rcn8Oii8JtgBoiCESB122Qoo2AYGWar5AMhmXy2k8csEPJkCknhMP7U 9Ry/LhN8FsovhNeJFhXYg12CgVVR/SF2jurwE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tcyO6Rxps6OniTZQW5Okchz4oIRX5z8zxSZOdhujk4k=; b=stEnJ5999ZhuCR9W3M8w7P9x8mCeJv83zdV6HCxoq7GZBWmlagE6Z7tiDrSIR/EYNl tA0CWahjpnwqlAcsf88OYJQm8PkFfo1DkZYcQ9Fyge8gpy715R2yCzoJn7s46iBVhSHZ nC7SYjEMeVFc944C8LZ+Z3abPIcURHHTGVzo4F+qmif1ljVye7OqfbprM8iQSANcztQ+ +9WegpsuZVHK82MIbiGDt6+t//c8H0fMsxRIsRyLqdgLdfu70UWcR+EVTGmFqOLAYS91 AWzEdAavSMzzxeUuKRqAgOXsDmgEsK1FvGOdXMQni78RQ/317Isu0iiFFtMpLqFyizhE yD3w== X-Gm-Message-State: AJIora+ByJlrPEzzlOBh4xTpy2l4NMcytXFp4O/m5vcFxzSUPnm1cwCP 9ASapnaVfnRpmml7AHxcSxQ0pg== X-Google-Smtp-Source: AGRyM1tC5HWSkKeVCVoz3swJkv8eg3zd9kGZHO8ptf6WNNEkSsTYRfswzUMyY4L/dY7WPb/tnE2jHw== X-Received: by 2002:a37:a884:0:b0:6ae:e67a:beec with SMTP id r126-20020a37a884000000b006aee67abeecmr12510146qke.401.1656440264520; Tue, 28 Jun 2022 11:17:44 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id s7-20020a05620a254700b006a65c58db99sm11776537qko.64.2022.06.28.11.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 11:17:43 -0700 (PDT) Date: Tue, 28 Jun 2022 14:17:42 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Priyanka Jain , "Peng Fan (OSS)" , u-boot@lists.denx.de Subject: Re: [PATCH v2] board: freescale: p1_p2_rdb_pc: Simplify SPL offset macros Message-ID: <20220628181742.GO1146598@bill-the-cat> References: <20220405131237.405-9-pali@kernel.org> <20220628175355.27817-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eHmdSDY+kY2au76U" Content-Disposition: inline In-Reply-To: <20220628175355.27817-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --eHmdSDY+kY2au76U Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2022 at 07:53:55PM +0200, Pali Roh=E1r wrote: > Now when CONFIG_SYS_TEXT_BASE has sane value, use it for calculation of > other SPL offset values: CONFIG_SPL_MAX_SIZE, CONFIG_SYS_MMC_U_BOOT_* and > CONFIG_SYS_SPI_FLASH_U_BOOT_* macros. >=20 > No functional change. >=20 > Signed-off-by: Pali Roh=E1r > --- > Changes in v2: > * Rebased on top of the U-Boot next branch, commit d61c11b8c894fad517677d= c51ee82d1eade39c01 > --- > include/configs/p1_p2_rdb_pc.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_p= c.h > index 56a16502dcc7..7237e3c1a63c 100644 > --- a/include/configs/p1_p2_rdb_pc.h > +++ b/include/configs/p1_p2_rdb_pc.h > @@ -78,15 +78,15 @@ > =20 > #ifdef CONFIG_SDCARD > #define CONFIG_SYS_MMC_U_BOOT_SIZE (768 << 10) > -#define CONFIG_SYS_MMC_U_BOOT_DST (0x11000000) > -#define CONFIG_SYS_MMC_U_BOOT_START (0x11000000) > -#define CONFIG_SYS_MMC_U_BOOT_OFFS (128 << 10) > +#define CONFIG_SYS_MMC_U_BOOT_DST CONFIG_SYS_TEXT_BASE > +#define CONFIG_SYS_MMC_U_BOOT_START CONFIG_SYS_TEXT_BASE > +#define CONFIG_SYS_MMC_U_BOOT_OFFS CONFIG_SPL_PAD_TO > #define CONFIG_SYS_MPC85XX_NO_RESETVEC > #elif defined(CONFIG_SPIFLASH) > #define CONFIG_SYS_SPI_FLASH_U_BOOT_SIZE (768 << 10) > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_DST (0x11000000) > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_START (0x11000000) > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_OFFS (128 << 10) > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_DST CONFIG_SYS_TEXT_BASE > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_START CONFIG_SYS_TEXT_BASE > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_OFFS CONFIG_SPL_PAD_TO > #define CONFIG_SYS_MPC85XX_NO_RESETVEC > #elif defined(CONFIG_MTD_RAW_NAND) > #ifdef CONFIG_TPL_BUILD So, this is entirely a PowerPC spl set of CONFIG variables. Can we move them to Kconfig, and use default xxx as you're changing them to above? The other platforms using this look to be doing the same at first glance. --=20 Tom --eHmdSDY+kY2au76U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmK7RcUACgkQFHw5/5Y0 tyzM/wwAiGRCNQ6tqMHFyEF4enLQe8VHgvYcdKeysaGAARneldXRuq6lhC3WDnfp Z6+z4a+brYLryG6OhMCXu3mem58i8TfQTbhwrqwTYv9phYMNAOEvPUdOG7l5ko4n HF7gvoW1BaNz44B0qeMTCAkIOJDpUm5P0Oixguzxwr/OLyB9OenlZkZReVjFu/3X SNRuBxy/377+06/dahS6rFuPTBKhnSshYVpm/Hvxr1fGl9DpxflFt1n2OctY+x6a 8gxC5cdUBfF25KTMIxZFFr+HNKht5S9Jrlj5b3dZM3ooK8bAK9r8ctA8wPlU3nst 0HOR3qY8fj0nMgFikJ+Ni84e0GbT5jHal4Mtj4DHyD7eJKOfKNdiWIi4dQyRqdsx rwjqqKHzXsO4bASTY1LB/Ws3vEBx3udxa0ZY0xxzS7W0owIw66OLUYAjkoB0hyoL 4ubt0d/2JPDAk4dStMmbo90DRM6egRAaOr9XcHBsPBwXkqNIRc3dxKpAfoBosG0T ztR88tHQ =MOOp -----END PGP SIGNATURE----- --eHmdSDY+kY2au76U--