From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1165BC433EF for ; Tue, 28 Jun 2022 18:53:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA4CB84428; Tue, 28 Jun 2022 20:53:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rxrI5AZP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 447DA84474; Tue, 28 Jun 2022 20:53:33 +0200 (CEST) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 471FB8407A for ; Tue, 28 Jun 2022 20:53:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf30.google.com with SMTP id p31so21412409qvp.5 for ; Tue, 28 Jun 2022 11:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lubMiLT1c/59YXLvPml/6DZS++/XO1/KTDJ5uiufc9Y=; b=rxrI5AZPeaA6rvR5q9qoRXPah48JTUh92PYxAqi4hucQEqHcKzHqEPCHavW8sG/6DO EF8XFyGlg77P9AMVwsdkqDKVKZr9ryKlie7HkU0pkW8Ob3Qj6Dwpjf1RkvrqOPcMIwup A1H1Q9QXdnWHb6madSngYFWX25xhfuEuzK9yk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lubMiLT1c/59YXLvPml/6DZS++/XO1/KTDJ5uiufc9Y=; b=adFhNqS5R6toK6MwuoBEG9Zp92IsfobGLPSkOu9O+hE3jnZFWnDZiZPkB839vFmVB1 17SIzf+2mcBR87BnvyZ3IFKYlolrJrDrQIgXECpXwlBRTor59HONXJx9uTfKKdsWLIWL OXMkTosH6+ZhFxHts5yCTr76u5s+7rMUAH3abnuh+whlhhOtqdxLAgqzfz8UrfUQcyoR c2SYnqqKuc6JCPCfZUwkMSPfH0q3qvnurVDDF7HIrkJhib5OqHYNa523yRd7YCBOIggs /cDZ6abijdqOhaju+BNiPRszvPNMrUK6XBMZLjJ44c7JmM31jQr9WVqzvFnZDkD5j3i/ Vkeg== X-Gm-Message-State: AJIora/DPuwjld86qSMYBO/LWJz+bKMpN7o0bkBSpQJmX+5SzV7GjR4Y fq6Ji3Iumn3oCfusIip+p2TkJA== X-Google-Smtp-Source: AGRyM1svpSXUS2+pixG5kQ5T3rs0Onbe5bGn5NjIlXdTk47RnmVC3E7iK9UEzQJhDl6qyRedjxfmtQ== X-Received: by 2002:ac8:6797:0:b0:31b:4b36:ea4 with SMTP id b23-20020ac86797000000b0031b4b360ea4mr6815275qtp.297.1656442408976; Tue, 28 Jun 2022 11:53:28 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id z198-20020a3765cf000000b006a736c8ea80sm11601914qkb.48.2022.06.28.11.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 11:53:28 -0700 (PDT) Date: Tue, 28 Jun 2022 14:53:26 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Priyanka Jain , "Peng Fan (OSS)" , u-boot@lists.denx.de Subject: Re: [PATCH v2] board: freescale: p1_p2_rdb_pc: Simplify SPL offset macros Message-ID: <20220628185326.GR1146598@bill-the-cat> References: <20220405131237.405-9-pali@kernel.org> <20220628175355.27817-1-pali@kernel.org> <20220628181742.GO1146598@bill-the-cat> <20220628182238.cmjhgpidicikyubo@pali> <20220628182852.GP1146598@bill-the-cat> <20220628183447.xnzwjxxnlabpf7on@pali> <20220628183911.GQ1146598@bill-the-cat> <20220628184144.5rygvzdznwgyb44j@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2qwbT0JTInWqknst" Content-Disposition: inline In-Reply-To: <20220628184144.5rygvzdznwgyb44j@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --2qwbT0JTInWqknst Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2022 at 08:41:44PM +0200, Pali Roh=E1r wrote: > On Tuesday 28 June 2022 14:39:11 Tom Rini wrote: > > On Tue, Jun 28, 2022 at 08:34:47PM +0200, Pali Roh=E1r wrote: > > > On Tuesday 28 June 2022 14:28:52 Tom Rini wrote: > > > > On Tue, Jun 28, 2022 at 08:22:38PM +0200, Pali Roh=E1r wrote: > > > > > On Tuesday 28 June 2022 14:17:42 Tom Rini wrote: > > > > > > On Tue, Jun 28, 2022 at 07:53:55PM +0200, Pali Roh=E1r wrote: > > > > > >=20 > > > > > > > Now when CONFIG_SYS_TEXT_BASE has sane value, use it for calc= ulation of > > > > > > > other SPL offset values: CONFIG_SPL_MAX_SIZE, CONFIG_SYS_MMC_= U_BOOT_* and > > > > > > > CONFIG_SYS_SPI_FLASH_U_BOOT_* macros. > > > > > > >=20 > > > > > > > No functional change. > > > > > > >=20 > > > > > > > Signed-off-by: Pali Roh=E1r > > > > > > > --- > > > > > > > Changes in v2: > > > > > > > * Rebased on top of the U-Boot next branch, commit d61c11b8c8= 94fad517677dc51ee82d1eade39c01 > > > > > > > --- > > > > > > > include/configs/p1_p2_rdb_pc.h | 12 ++++++------ > > > > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > >=20 > > > > > > > diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs= /p1_p2_rdb_pc.h > > > > > > > index 56a16502dcc7..7237e3c1a63c 100644 > > > > > > > --- a/include/configs/p1_p2_rdb_pc.h > > > > > > > +++ b/include/configs/p1_p2_rdb_pc.h > > > > > > > @@ -78,15 +78,15 @@ > > > > > > > =20 > > > > > > > #ifdef CONFIG_SDCARD > > > > > > > #define CONFIG_SYS_MMC_U_BOOT_SIZE (768 << 10) > > > > > > > -#define CONFIG_SYS_MMC_U_BOOT_DST (0x11000000) > > > > > > > -#define CONFIG_SYS_MMC_U_BOOT_START (0x11000000) > > > > > > > -#define CONFIG_SYS_MMC_U_BOOT_OFFS (128 << 10) > > > > > > > +#define CONFIG_SYS_MMC_U_BOOT_DST CONFIG_SYS_TEXT_BASE > > > > > > > +#define CONFIG_SYS_MMC_U_BOOT_START CONFIG_SYS_TEXT_BASE > > > > > > > +#define CONFIG_SYS_MMC_U_BOOT_OFFS CONFIG_SPL_PAD_TO > > > > > > > #define CONFIG_SYS_MPC85XX_NO_RESETVEC > > > > > > > #elif defined(CONFIG_SPIFLASH) > > > > > > > #define CONFIG_SYS_SPI_FLASH_U_BOOT_SIZE (768 << 10) > > > > > > > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_DST (0x11000000) > > > > > > > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_START (0x11000000) > > > > > > > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_OFFS (128 << 10) > > > > > > > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_DST CONFIG_SYS_TEXT_BASE > > > > > > > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_START CONFIG_SYS_TEXT_BA= SE > > > > > > > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_OFFS CONFIG_SPL_PAD_TO > > > > > > > #define CONFIG_SYS_MPC85XX_NO_RESETVEC > > > > > > > #elif defined(CONFIG_MTD_RAW_NAND) > > > > > > > #ifdef CONFIG_TPL_BUILD > > > > > >=20 > > > > > > So, this is entirely a PowerPC spl set of CONFIG variables. Ca= n we move > > > > > > them to Kconfig, and use default xxx as you're changing them to= above? > > > > > > The other platforms using this look to be doing the same at fir= st > > > > > > glance. > > > > > >=20 > > > > > > --=20 > > > > > > Tom > > > > >=20 > > > > > Not sure how to do it right now. CONFIG_SYS_MMC_U_BOOT_OFFS would= need > > > > > to be adjusted by size of boot sector, as is in this patch: > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220405134032.7= 04-3-pali@kernel.org/ > > > > >=20 > > > > > So I just sent patch in current form which simplify definitions of > > > > > CONFIG_SYS_MMC_U_BOOT_* and CONFIG_SYS_SPI_FLASH_U_BOOT_* macros. > > > >=20 > > > > Given the limited places we use CONFIG_SYS_MMC_U_BOOT_OFFS (two spo= ts, > > > > one file), remove it from CONFIG space, make it file local, and > > > > FSL_PREPBL_ESDHC_BOOT_SECTOR will be in Kconfig to start with? I'm > > > > taking a harder look at what CONFIG_SYS_* can be moved to Kconfig, = and > > > > what needs to be just something else, and what can be cleaned up / > > > > removed, so I really want to figure out a solution here that migrat= es > > > > the symbols or removes them from CONFIG namespace. > > > >=20 > > > > --=20 > > > > Tom > > >=20 > > > More than month ago I proposed different solution, prepare codebase to > > > completely drop CONFIG_SYS_MMC_U_BOOT_OFFS option. But nobody reacted= to > > > it and now I see on patchwork just "Changes Requested". > > > https://patchwork.ozlabs.org/project/uboot/patch/20220511183332.1362-= 2-pali@kernel.org/ > >=20 > > Er, I see > > https://patchwork.ozlabs.org/project/uboot/patch/20220511183332.1362-1-= pali@kernel.org/ > > notes it fails to build, so that's probably the changes requested. > >=20 > > --=20 > > Tom >=20 > V2 for that build failure already exists and half hour ago I sent > another reminder for v2: > https://lore.kernel.org/u-boot/20220628181436.iwmwvvoithgwp6pu@pali/ > but it has nothing with CONFIG_SYS_MMC_U_BOOT_OFFS... Patch 1/3 in the series causes fails to build errors, the whole series gets changes requested, that's normal to me and expecting the whole series to be reposted. --=20 Tom --2qwbT0JTInWqknst Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmK7TiMACgkQFHw5/5Y0 tyzoUQv+L+Pt9LTnP7/aA0FJWWYei2n17Lnbl0+yXujYmRN3JVGLp60CS0tSqEDF 4duuEfx9k+b2nETB6ngK31aw0fVRw4g5Ns2dWl3XKSZA3HK+JC+gOU3zKQHKCwCH CdYb7qF8a6MH/ULb5EN/d5Q8wn0bgJC+JG/NLOIAvRp2SNh7Jm0LrCPYVhiMksQw RhOwyTzwZEW7CmWwOCVHoJq8RRZuzvvEFNk2Ch2LqxhxJpmNCd4Att1xHp84oEDg gBs5gwGrPTv1jUH47MyWPFtK9h/U3PYJCnb4JZMaCMEdVPRCve3/7JobH0qGFI2E bWgI2cnjtV3l+K7Jw7U3eEQY2Ed7Z+3R86wNptPpIFJTLMZifnjnPe6wcRbqa8eQ 01EuCmfqWBDdCiSI3IsfneKFiaXiovHk1CBlxzK4Vq1qNmDOUr+K3YiPQ8OVEGd4 vEanGgS2yyURyQNTfMGWjQMzE8TJ/7zWd0JHrtFMi1y7IObhz7UAP0ukTUBOoSdv C1qKztm+ =FTbM -----END PGP SIGNATURE----- --2qwbT0JTInWqknst--