From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Thomas Richter <tmricht@linux.ibm.com>,
Claire Jensen <cjense@google.com>,
Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>
Subject: [PATCH] perf test: Skip for paranoid 3
Date: Tue, 28 Jun 2022 20:40:07 -0700 [thread overview]
Message-ID: <20220629034007.332804-1-irogers@google.com> (raw)
Add skip tests for paranoid level being 3.
Rather than skipping lines starting "Failed", skip lines containing
"failed" - making the behavior consistent with the previous python
version.
Fixes: ec906102e5b7 ("perf test: Fix "perf stat CSV output linter" test on s390")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/stat+csv_output.sh | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/tools/perf/tests/shell/stat+csv_output.sh b/tools/perf/tests/shell/stat+csv_output.sh
index 38c26f3ef4c1..b165c81fccb4 100755
--- a/tools/perf/tests/shell/stat+csv_output.sh
+++ b/tools/perf/tests/shell/stat+csv_output.sh
@@ -26,9 +26,8 @@ function commachecker()
while read line
do
- # Check for lines beginning with Failed
- x=${line:0:6}
- [ "$x" = "Failed" ] && continue
+ # Skip lines containing failed.
+ (echo "$line" | grep -q "failed") && continue
# Count the number of commas
x=$(echo $line | tr -d -c ',')
@@ -51,6 +50,11 @@ function ParanoidAndNotRoot()
check_no_args()
{
echo -n "Checking CSV output: no args "
+ if ParanoidAndNotRoot 2
+ then
+ echo "[Skip] paranoid and not root"
+ return
+ fi
perf stat -x, true 2>&1 | commachecker --no-args
echo "[Success]"
}
@@ -83,6 +87,11 @@ check_system_wide_no_aggr()
check_interval()
{
echo -n "Checking CSV output: interval "
+ if ParanoidAndNotRoot 2
+ then
+ echo "[Skip] paranoid and not root"
+ return
+ fi
perf stat -x, -I 1000 true 2>&1 | commachecker --interval
echo "[Success]"
}
@@ -91,6 +100,11 @@ check_interval()
check_event()
{
echo -n "Checking CSV output: event "
+ if ParanoidAndNotRoot 2
+ then
+ echo "[Skip] paranoid and not root"
+ return
+ fi
perf stat -x, -e cpu-clock true 2>&1 | commachecker --event
echo "[Success]"
}
--
2.37.0.rc0.161.g10f37bed90-goog
next reply other threads:[~2022-06-29 3:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 3:40 Ian Rogers [this message]
2022-06-30 9:11 ` [PATCH] perf test: Skip for paranoid 3 Peter Zijlstra
2022-06-30 20:59 ` Ian Rogers
2022-07-01 8:55 ` Peter Zijlstra
2022-07-01 15:16 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629034007.332804-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=cjense@google.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.