From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712BEC433EF for ; Wed, 29 Jun 2022 05:20:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231187AbiF2FUR (ORCPT ); Wed, 29 Jun 2022 01:20:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbiF2FUR (ORCPT ); Wed, 29 Jun 2022 01:20:17 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C671A3123F for ; Tue, 28 Jun 2022 22:20:15 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 730BA67373; Wed, 29 Jun 2022 07:20:11 +0200 (CEST) Date: Wed, 29 Jun 2022 07:20:11 +0200 From: Christoph Hellwig To: Jason Yan Cc: tj@kernel.org, jack@suse.cz, hch@lst.de, axboe@kernel.dk, linux-block@vger.kernel.org Subject: Re: [PATCH v2 1/2] blk-cgroup: factor out blkcg_iostat_update() Message-ID: <20220629052011.GA16113@lst.de> References: <20220629015022.2667445-1-yanaijie@huawei.com> <20220629015022.2667445-2-yanaijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220629015022.2667445-2-yanaijie@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jun 29, 2022 at 09:50:21AM +0800, Jason Yan wrote: > +static void blkcg_iostat_update(struct blkcg_gq *blkg, > + struct blkg_iostat *cur, struct blkg_iostat *last) Incorrect indentation. Continuing prototype lines are indented either using two tabs or after the opening brace. The rest looks good: Reviewed-by: Christoph Hellwig