From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>,
Petar Penkov <ppenkov@aviatrix.com>
Subject: Re: [PATCH net] net: tun: do not call napi_disable() twice
Date: Wed, 29 Jun 2022 09:17:50 -0700 [thread overview]
Message-ID: <20220629091750.1f0dc8ed@kernel.org> (raw)
In-Reply-To: <20220629093752.1935215-1-edumazet@google.com>
On Wed, 29 Jun 2022 09:37:52 +0000 Eric Dumazet wrote:
> syzbot reported a hang in tun_napi_disable() while RTNL is held.
>
> Because tun.c logic is complicated, I chose to:
>
> 1) rename tun->napi_enabled to tun->napi_configured
>
> 2) Add a new boolean, tracking if tun->napi is enabled or not.
Not a huge surprise TBH :S
Is there a repro?
next prev parent reply other threads:[~2022-06-29 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 9:37 [PATCH net] net: tun: do not call napi_disable() twice Eric Dumazet
2022-06-29 16:17 ` Jakub Kicinski [this message]
2022-06-29 16:19 ` Eric Dumazet
2022-06-29 16:27 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629091750.1f0dc8ed@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ppenkov@aviatrix.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.