From: "Michael S. Tsirkin" <mst@redhat.com>
To: Brice Goglin <Brice.Goglin@inria.fr>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Liu Jingqi" <jingqi.liu@intel.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>,
"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH v4 1/4] hmat acpi: Don't require initiator value in -numa
Date: Thu, 30 Jun 2022 09:28:22 -0400 [thread overview]
Message-ID: <20220630092554-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <01981dd2-aa15-fbb1-f344-f1065fa06951@inria.fr>
On Thu, Jun 30, 2022 at 09:40:19AM +0200, Brice Goglin wrote:
...
>
> Before this patch, we had to add ",initiator=X" to "-numa node,nodeid=2,memdev=ram2".
> The lstopo output difference between initiator=1 and no initiator is:
> @@ -1,10 +1,10 @@
> Machine (2966MB total) + Package P#0
> + NUMANode P#2 (979MB)
> Group0
> NUMANode P#0 (980MB)
> Core P#0 + PU P#0
> Core P#1 + PU P#1
> Group0
> NUMANode P#1 (1007MB)
> - NUMANode P#2 (979MB)
> Core P#2 + PU P#2
> Core P#3 + PU P#3
>
> Corresponding changes in the HMAT MPDA structure:
> @@ -49,10 +49,10 @@
> [078h 0120 2] Structure Type : 0000 [Memory Proximity Domain Attributes]
> [07Ah 0122 2] Reserved : 0000
> [07Ch 0124 4] Length : 00000028
> -[080h 0128 2] Flags (decoded below) : 0001
> - Processor Proximity Domain Valid : 1
> +[080h 0128 2] Flags (decoded below) : 0000
Including diff output like this is what is confusing
mail processing tools. Just escape the diff in the output
and this will make git happy. E.g.:
The lstopo output difference between initiator=1 and no initiator is:
| @@ -1,10 +1,10 @@
| Machine (2966MB total) + Package P#0
| + NUMANode P#2 (979MB)
| Group0
| NUMANode P#0 (980MB)
| Core P#0 + PU P#0
| Core P#1 + PU P#1
| Group0
| NUMANode P#1 (1007MB)
| - NUMANode P#2 (979MB)
| Core P#2 + PU P#2
| Core P#3 + PU P#3
|
| Corresponding changes in the HMAT MPDA structure:
| @@ -49,10 +49,10 @@
| [078h 0120 2] Structure Type : 0000 [Memory Proximity Domain Attributes]
| [07Ah 0122 2] Reserved : 0000
| [07Ch 0124 4] Length : 00000028
| -[080h 0128 2] Flags (decoded below) : 0001
| - Processor Proximity Domain Valid : 1
| +[080h 0128 2] Flags (decoded below) : 0000
--
MST
next prev parent reply other threads:[~2022-06-30 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 7:36 [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa Brice Goglin
2022-06-30 7:40 ` [PATCH v4 1/4] " Brice Goglin
2022-06-30 13:28 ` Michael S. Tsirkin [this message]
2022-06-30 7:40 ` [PATCH v4 2/4] tests: acpi: add and whitelist *.hmat-noinitiator expected blobs Brice Goglin
2022-06-30 7:41 ` [PATCH v4 3/4] tests: acpi: q35: add test for hmat nodes without initiators Brice Goglin
2022-06-30 7:41 ` [PATCH v4 4/4] tests: acpi: q35: update expected blobs *.hmat-noinitiators Brice Goglin
2022-06-30 12:23 ` [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa Igor Mammedov
2022-06-30 12:40 ` Brice Goglin
2022-06-30 12:56 ` Igor Mammedov
2022-06-30 13:29 ` Michael S. Tsirkin
2022-06-30 13:30 ` Michael S. Tsirkin
2022-07-01 16:08 ` Jonathan Cameron via
2022-07-04 9:07 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630092554-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Brice.Goglin@inria.fr \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=jingqi.liu@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.