From: Jason Gunthorpe <jgg@nvidia.com>
To: kernel test robot <lkp@intel.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
alex.williamson@redhat.com, kbuild-all@lists.01.org,
saeedm@nvidia.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
kuba@kernel.org, kevin.tian@intel.com, joao.m.martins@oracle.com,
leonro@nvidia.com, maorg@nvidia.com, cohuck@redhat.com
Subject: Re: [PATCH vfio 08/13] vfio: Introduce the DMA logging feature support
Date: Thu, 30 Jun 2022 10:48:24 -0300 [thread overview]
Message-ID: <20220630134824.GK693670@nvidia.com> (raw)
In-Reply-To: <202206302140.XlWYhlXa-lkp@intel.com>
On Thu, Jun 30, 2022 at 09:40:01PM +0800, kernel test robot wrote:
> 1636 nnodes = control.num_ranges;
> 1637 if (!nnodes || nnodes > LOG_MAX_RANGES)
> 1638 return -EINVAL;
> 1639
> > 1640 ranges = (struct vfio_device_feature_dma_logging_range __user *)
> 1641 control.ranges;
Things like this should always use u64_to_user_ptr()
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH vfio 08/13] vfio: Introduce the DMA logging feature support
Date: Thu, 30 Jun 2022 10:48:24 -0300 [thread overview]
Message-ID: <20220630134824.GK693670@nvidia.com> (raw)
In-Reply-To: <202206302140.XlWYhlXa-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Thu, Jun 30, 2022 at 09:40:01PM +0800, kernel test robot wrote:
> 1636 nnodes = control.num_ranges;
> 1637 if (!nnodes || nnodes > LOG_MAX_RANGES)
> 1638 return -EINVAL;
> 1639
> > 1640 ranges = (struct vfio_device_feature_dma_logging_range __user *)
> 1641 control.ranges;
Things like this should always use u64_to_user_ptr()
Jason
next prev parent reply other threads:[~2022-06-30 13:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 10:25 [PATCH vfio 00/13] Add device DMA logging support for mlx5 driver Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 01/13] vfio/mlx5: Protect mlx5vf_disable_fds() upon close device Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 02/13] vfio: Split migration ops from main device ops Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 03/13] net/mlx5: Introduce ifc bits for page tracker Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 04/13] net/mlx5: Query ADV_VIRTUALIZATION capabilities Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 05/13] vfio: Introduce DMA logging uAPIs Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 06/13] vfio: Move vfio.c to vfio_main.c Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 07/13] vfio: Add an IOVA bitmap support Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 08/13] vfio: Introduce the DMA logging feature support Yishai Hadas
2022-06-30 13:40 ` kernel test robot
2022-06-30 13:48 ` Jason Gunthorpe [this message]
2022-06-30 13:48 ` Jason Gunthorpe
2022-07-01 4:24 ` kernel test robot
2022-07-01 4:55 ` kernel test robot
2022-06-30 10:25 ` [PATCH vfio 09/13] vfio/mlx5: Init QP based resources for dirty tracking Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 10/13] vfio/mlx5: Create and destroy page tracker object Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 11/13] vfio/mlx5: Report dirty pages from tracker Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 12/13] vfio/mlx5: Manage error scenarios on tracker Yishai Hadas
2022-06-30 10:25 ` [PATCH vfio 13/13] vfio/mlx5: Set the driver DMA logging callbacks Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630134824.GK693670@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=lkp@intel.com \
--cc=maorg@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.