From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82C69C43334 for ; Thu, 30 Jun 2022 14:31:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 01B3E8463E; Thu, 30 Jun 2022 14:31:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 01B3E8463E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CfLT-NdWJnyf; Thu, 30 Jun 2022 14:31:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id DB5A6845CD; Thu, 30 Jun 2022 14:31:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org DB5A6845CD Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BE6A6C0021; Thu, 30 Jun 2022 14:31:25 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8DC29C0011 for ; Thu, 30 Jun 2022 14:31:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 544B842408 for ; Thu, 30 Jun 2022 14:31:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 544B842408 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lxpikd6Fb1gA for ; Thu, 30 Jun 2022 14:31:23 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 34D0142406 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp4.osuosl.org (Postfix) with ESMTPS id 34D0142406 for ; Thu, 30 Jun 2022 14:31:22 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id AF95368AA6; Thu, 30 Jun 2022 16:31:16 +0200 (CEST) Date: Thu, 30 Jun 2022 16:31:16 +0200 From: Christoph Hellwig To: Ren Zhijie Subject: Re: [PATCH -next] dma-mapping: Fix build error unused-value Message-ID: <20220630143116.GA6198@lst.de> References: <20220630123528.251181-1-renzhijie2@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220630123528.251181-1-renzhijie2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: mathieu.poirier@linaro.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, robin.murphy@arm.com, hch@lst.de, mark-pk.tsai@mediatek.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Thanks, this looks good with a minor nit below: Reviewed-by: Christoph Hellwig Mathieu, can you pick this up through your tree as that is where the offending commit was merged through? > Fixes: e61c451476e6("dma-mapping: Add dma_release_coherent_memory to DMA API") missing space before the opening brace here. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105416D19 for ; Thu, 30 Jun 2022 14:31:27 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id AF95368AA6; Thu, 30 Jun 2022 16:31:16 +0200 (CEST) Date: Thu, 30 Jun 2022 16:31:16 +0200 From: Christoph Hellwig To: Ren Zhijie Cc: hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, mathieu.poirier@linaro.org, mark-pk.tsai@mediatek.com, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] dma-mapping: Fix build error unused-value Message-ID: <20220630143116.GA6198@lst.de> References: <20220630123528.251181-1-renzhijie2@huawei.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630123528.251181-1-renzhijie2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Message-ID: <20220630143116.MTO_7n5hcowZDRpyHLMQ1-AZhoeT1HYyM8c9MqXGgzM@z> Thanks, this looks good with a minor nit below: Reviewed-by: Christoph Hellwig Mathieu, can you pick this up through your tree as that is where the offending commit was merged through? > Fixes: e61c451476e6("dma-mapping: Add dma_release_coherent_memory to DMA API") missing space before the opening brace here.