* main - lvmdbusd: Correct conditional for lvm child process running
@ 2022-06-30 16:00 Tony Asleson
0 siblings, 0 replies; only message in thread
From: Tony Asleson @ 2022-06-30 16:00 UTC (permalink / raw)
To: lvm-devel
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=37733cd4eb5116db371ac1ae6e971e3c336c3ddb
Commit: 37733cd4eb5116db371ac1ae6e971e3c336c3ddb
Parent: db5277c97155632ce83e1125e348eda97c871968
Author: Tony Asleson <tasleson@redhat.com>
AuthorDate: Wed May 25 15:51:14 2022 -0500
Committer: Tony Asleson <tasleson@redhat.com>
CommitterDate: Thu Jun 30 10:55:16 2022 -0500
lvmdbusd: Correct conditional for lvm child process running
Poll returns None when process is running, else exit value. If poll returns
0 we will fail to exit the select loop.
---
daemons/lvmdbusd/lvm_shell_proxy.py.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/daemons/lvmdbusd/lvm_shell_proxy.py.in b/daemons/lvmdbusd/lvm_shell_proxy.py.in
index 7816daa8b..78fe1e422 100644
--- a/daemons/lvmdbusd/lvm_shell_proxy.py.in
+++ b/daemons/lvmdbusd/lvm_shell_proxy.py.in
@@ -75,7 +75,7 @@ class LVMShellProxy(object):
stderr += read_decoded(self.lvm_shell.stderr)
# Check to see if the lvm process died on us
- if self.lvm_shell.poll():
+ if self.lvm_shell.poll() is not None:
raise Exception(self.lvm_shell.returncode, "%s" % stderr)
if stdout.endswith(SHELL_PROMPT):
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-30 16:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-30 16:00 main - lvmdbusd: Correct conditional for lvm child process running Tony Asleson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.