From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7F1AC43334 for ; Mon, 4 Jul 2022 11:26:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA1831746; Mon, 4 Jul 2022 13:25:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA1831746 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1656934003; bh=xUOMsKjDTA1x1Y92MvlaZyGA95YSgXwQjWm/uO1s1iE=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dXMEdvgX9aIvo731dAHUy8I2aM6CxD0/vJUvA9tyuPGGUO6tcSsbGW22+woWKTeyz v0R5iLCNsojz4BBeJ9UKG0qBv4AtZk4OxvLHa3j9P7U3FdezGP3ZhtTrvjYQdfxM5w CXirQm6jCIrkTgdjCM9rtkymiujyzEeilc4Qx4i4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1365FF80579; Mon, 4 Jul 2022 13:23:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 010F0F804D8; Thu, 30 Jun 2022 18:57:28 +0200 (CEST) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A0D6EF800F5 for ; Thu, 30 Jun 2022 18:57:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A0D6EF800F5 Received: by mail-il1-f181.google.com with SMTP id a16so12779270ilr.6 for ; Thu, 30 Jun 2022 09:57:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cSCjzkkaYP9MYdWZQafK4xMoYiSrEDWkLIVS/pLNRR8=; b=geOEW423ggFaDnj6TDWkb0nnkKWhCju3eTOkAMA1Cugz3IApUiW9GbukLt4TePqxzL f9hA8WA9cDmdusXSRI0tT+pRqIj7cAtcqYj5CHtANRONPndS76vEYre3nB1q2k7qeKZ7 XErUry5WriGYCAw80O7SxFYAjIvAqXSBdmDLuW1QLJL33DzcbSvdJoliaEe7kQfFJAo2 KTkJieB6pbAiS0CGbkr/7OFV3d3UJmSxopX/TX27lbA9o5IPf4FLDmJMPVFf59pp19cb sZZAJoIJpGbUxASZfsYHTKdtwptOQJti+wjE0PHuhtE06paag3Q/FWmHuZi8J29spmc0 9nMA== X-Gm-Message-State: AJIora8vzZurNI+lo//uAhurjzohevljaK2/KUhz8KKCb7KoM0cqoaOL aoiVMorh9yVsENSFZMxpWg== X-Google-Smtp-Source: AGRyM1ur4AOc7bK5eVjgml5dO/I1YI3o54vzy9DsjE/7iDAB6CuVvnaI9nMRxVWdksw+oB2ay497Pw== X-Received: by 2002:a92:cd8f:0:b0:2d9:5d44:6a53 with SMTP id r15-20020a92cd8f000000b002d95d446a53mr5817684ilb.226.1656608240763; Thu, 30 Jun 2022 09:57:20 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q25-20020a05663810d900b0032e1a07228asm8851588jad.26.2022.06.30.09.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 09:57:20 -0700 (PDT) Received: (nullmailer pid 2895373 invoked by uid 1000); Thu, 30 Jun 2022 16:57:17 -0000 Date: Thu, 30 Jun 2022 10:57:17 -0600 From: Rob Herring To: Conor Dooley Subject: Re: [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width Message-ID: <20220630165717.GA2895317-robh@kernel.org> References: <20220629184343.3438856-1-mail@conchuod.ie> <20220629184343.3438856-5-mail@conchuod.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220629184343.3438856-5-mail@conchuod.ie> X-Mailman-Approved-At: Mon, 04 Jul 2022 13:23:02 +0200 Cc: Niklas Cassel , alsa-devel@alsa-project.org, David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Conor Dooley , Thierry Reding , Krzysztof Kozlowski , linux-riscv@lists.infradead.org, Sam Ravnborg , Masahiro Yamada , Daniel Lezcano , Jose Abreu , Geert Uytterhoeven , Eugeniy Paltsev , devicetree@vger.kernel.org, Albert Ou , Mark Brown , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Dillon Min , Liam Girdwood , Serge Semin , linux-spi@vger.kernel.org, Vinod Koul , Rob Herring , Palmer Dabbelt , Daniel Vetter , dmaengine@vger.kernel.org, Damien Le Moal X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 29 Jun 2022 19:43:33 +0100, Conor Dooley wrote: > From: Conor Dooley > > Most users of dw-apb-ssi use spi-{r,t}x-bus-width of 1, however the > Canaan k210 is wired up for a width of 4. > Quoting Serge: > The modern DW APB SSI controllers of v.4.* and newer also support the > enhanced SPI Modes too (Dual, Quad and Octal). Since the IP-core > version is auto-detected at run-time there is no way to create a > DT-schema correctly constraining the Rx/Tx SPI bus widths. > /endquote > > As such, drop the restriction on only supporting a bus width of 1. > > Link: https://lore.kernel.org/all/20220620205654.g7fyipwytbww5757@mobilestation/ > Signed-off-by: Conor Dooley > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ------ > 1 file changed, 6 deletions(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E51C433EF for ; Thu, 30 Jun 2022 16:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbiF3Q50 (ORCPT ); Thu, 30 Jun 2022 12:57:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236287AbiF3Q5W (ORCPT ); Thu, 30 Jun 2022 12:57:22 -0400 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC07393DC; Thu, 30 Jun 2022 09:57:21 -0700 (PDT) Received: by mail-il1-f181.google.com with SMTP id p9so12491515ilj.7; Thu, 30 Jun 2022 09:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cSCjzkkaYP9MYdWZQafK4xMoYiSrEDWkLIVS/pLNRR8=; b=JmV7Xak6rkAw/IIrTD8iY8w38WPI88kBk7nLKfjetfg04LNFPiUXEDkjmISZec4N3H GXm40CZ9XEeDb7iLPScDqs5zcJ179gLte5Oe2F/UogWu8POy64s6v4c3A5uoJxwi/uPr ohFaziFaTPf0Ko3EnxK7cclEo3VI468FmXqzg/RxVDIXadLL3bae36JGdbQwLhk0Ub7n VomTJEN8tIkBhmTGtiEEDpsVI9eEH3jew/PnM4pmqkD67oowqrRdCqq1AV6UmYHcNygO nDRAHxjpZN7LbKkfYy9Vpk8JG+fQdTxx7jb2DlX5yuChgUU8sIrnkYhF/F3x9UAgknGj +i5A== X-Gm-Message-State: AJIora9y36wf4Doxgne49ArSEUSsprnUYoqnFz1swjH4XBazdC6ae11M DzsLBO7dYtuvLs/GDsY8tKB48z0tPA== X-Google-Smtp-Source: AGRyM1ur4AOc7bK5eVjgml5dO/I1YI3o54vzy9DsjE/7iDAB6CuVvnaI9nMRxVWdksw+oB2ay497Pw== X-Received: by 2002:a92:cd8f:0:b0:2d9:5d44:6a53 with SMTP id r15-20020a92cd8f000000b002d95d446a53mr5817684ilb.226.1656608240763; Thu, 30 Jun 2022 09:57:20 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q25-20020a05663810d900b0032e1a07228asm8851588jad.26.2022.06.30.09.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 09:57:20 -0700 (PDT) Received: (nullmailer pid 2895373 invoked by uid 1000); Thu, 30 Jun 2022 16:57:17 -0000 Date: Thu, 30 Jun 2022 10:57:17 -0600 From: Rob Herring To: Conor Dooley Cc: Daniel Lezcano , Palmer Dabbelt , dmaengine@vger.kernel.org, Thomas Gleixner , Geert Uytterhoeven , Liam Girdwood , alsa-devel@alsa-project.org, Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Jose Abreu , devicetree@vger.kernel.org, Serge Semin , Masahiro Yamada , Sam Ravnborg , Daniel Vetter , Thierry Reding , David Airlie , Damien Le Moal , Vinod Koul , Dillon Min , linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, Paul Walmsley , Mark Brown , Albert Ou , Conor Dooley , Palmer Dabbelt , Niklas Cassel , Rob Herring , Eugeniy Paltsev , linux-spi@vger.kernel.org Subject: Re: [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width Message-ID: <20220630165717.GA2895317-robh@kernel.org> References: <20220629184343.3438856-1-mail@conchuod.ie> <20220629184343.3438856-5-mail@conchuod.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220629184343.3438856-5-mail@conchuod.ie> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, 29 Jun 2022 19:43:33 +0100, Conor Dooley wrote: > From: Conor Dooley > > Most users of dw-apb-ssi use spi-{r,t}x-bus-width of 1, however the > Canaan k210 is wired up for a width of 4. > Quoting Serge: > The modern DW APB SSI controllers of v.4.* and newer also support the > enhanced SPI Modes too (Dual, Quad and Octal). Since the IP-core > version is auto-detected at run-time there is no way to create a > DT-schema correctly constraining the Rx/Tx SPI bus widths. > /endquote > > As such, drop the restriction on only supporting a bus width of 1. > > Link: https://lore.kernel.org/all/20220620205654.g7fyipwytbww5757@mobilestation/ > Signed-off-by: Conor Dooley > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ------ > 1 file changed, 6 deletions(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4857C433EF for ; Thu, 30 Jun 2022 16:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=68vwvox9ieq6pvm1YBuSboBRDugwN6W5AUKRzGLoVtU=; b=uN+QDaubn3e8mO NShPhnRtiWCRbgNpLonuGOYdDuiy8OPjlLSci6pd6v9AY1M8ZM2jgWzCqFmXjGN8E6CbucrQd7dNq lisSiTd1B9Hd4dZgzwxt0GlioLrlGcq/2GQWkcoUY6V2QEucxzEQThreXjLC6e+fJ/UKExa6Xx8nv drPHYY4XwyY4+v3nTuSZ8ODCGswxIluMps6zrAg5YB+5s01DWUggG0eLJohSSPMxpjkbSdSA5olBN jWKKQ99yrBAQYrYBltykmS2VSlxODDukA+3jEggwoGQyCEJxtw0uIMDgayBcivy8bjDWDWx3m/n6u 9rgFFJGZZPMwrODAmXqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6xTp-000iH3-2s; Thu, 30 Jun 2022 16:57:25 +0000 Received: from mail-il1-f173.google.com ([209.85.166.173]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6xTl-000iFb-T4 for linux-riscv@lists.infradead.org; Thu, 30 Jun 2022 16:57:23 +0000 Received: by mail-il1-f173.google.com with SMTP id p14so12800262ile.1 for ; Thu, 30 Jun 2022 09:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cSCjzkkaYP9MYdWZQafK4xMoYiSrEDWkLIVS/pLNRR8=; b=tibEKBsu2drDAItj5ms4VTycFxj8pE5pqMv4JHvqYGO1L4R+aysQhD10prBOiCIq9j +I1BTSBBmXccwRQgSaTtc5M/gKHZbjXjYWeL/vF1Fmhl3TV9HZm8p/RrJfilWNVqhPDL IKTaCbGdawMmOwR+71zoGoYwT/vKAW/jmdLFR5d7eWn6VKjsDnaBgIlsX4QalwfTJXk8 nhTbzUZ3jusnOHJ36KgOwyoHqZ8NQ6GpgiTBIPnof6dOjfU+k2GYbyWJvbX5CQ6tfdzO cGnrN7d8Wi9+j//V99sOvgsISFibdAnQuMHFU7c5eLbb9wyLrE9L1yDsQujx6t5r9VdO Twng== X-Gm-Message-State: AJIora9PZrqnLkCevQW687GLfXLZTDLXHQeOaE69dJcivcxZwtSNY5ac 5/P0cf2XiqlU1GXjmDW9lw== X-Google-Smtp-Source: AGRyM1ur4AOc7bK5eVjgml5dO/I1YI3o54vzy9DsjE/7iDAB6CuVvnaI9nMRxVWdksw+oB2ay497Pw== X-Received: by 2002:a92:cd8f:0:b0:2d9:5d44:6a53 with SMTP id r15-20020a92cd8f000000b002d95d446a53mr5817684ilb.226.1656608240763; Thu, 30 Jun 2022 09:57:20 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q25-20020a05663810d900b0032e1a07228asm8851588jad.26.2022.06.30.09.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 09:57:20 -0700 (PDT) Received: (nullmailer pid 2895373 invoked by uid 1000); Thu, 30 Jun 2022 16:57:17 -0000 Date: Thu, 30 Jun 2022 10:57:17 -0600 From: Rob Herring To: Conor Dooley Cc: Daniel Lezcano , Palmer Dabbelt , dmaengine@vger.kernel.org, Thomas Gleixner , Geert Uytterhoeven , Liam Girdwood , alsa-devel@alsa-project.org, Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Jose Abreu , devicetree@vger.kernel.org, Serge Semin , Masahiro Yamada , Sam Ravnborg , Daniel Vetter , Thierry Reding , David Airlie , Damien Le Moal , Vinod Koul , Dillon Min , linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, Paul Walmsley , Mark Brown , Albert Ou , Conor Dooley , Palmer Dabbelt , Niklas Cassel , Rob Herring , Eugeniy Paltsev , linux-spi@vger.kernel.org Subject: Re: [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width Message-ID: <20220630165717.GA2895317-robh@kernel.org> References: <20220629184343.3438856-1-mail@conchuod.ie> <20220629184343.3438856-5-mail@conchuod.ie> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220629184343.3438856-5-mail@conchuod.ie> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220630_095721_973601_5304F955 X-CRM114-Status: GOOD ( 12.85 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 29 Jun 2022 19:43:33 +0100, Conor Dooley wrote: > From: Conor Dooley > > Most users of dw-apb-ssi use spi-{r,t}x-bus-width of 1, however the > Canaan k210 is wired up for a width of 4. > Quoting Serge: > The modern DW APB SSI controllers of v.4.* and newer also support the > enhanced SPI Modes too (Dual, Quad and Octal). Since the IP-core > version is auto-detected at run-time there is no way to create a > DT-schema correctly constraining the Rx/Tx SPI bus widths. > /endquote > > As such, drop the restriction on only supporting a bus width of 1. > > Link: https://lore.kernel.org/all/20220620205654.g7fyipwytbww5757@mobilestation/ > Signed-off-by: Conor Dooley > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ------ > 1 file changed, 6 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AE7FC43334 for ; Thu, 30 Jun 2022 16:57:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 492C7113C8A; Thu, 30 Jun 2022 16:57:22 +0000 (UTC) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71A7C113C7E for ; Thu, 30 Jun 2022 16:57:21 +0000 (UTC) Received: by mail-il1-f170.google.com with SMTP id i17so12741223ils.12 for ; Thu, 30 Jun 2022 09:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cSCjzkkaYP9MYdWZQafK4xMoYiSrEDWkLIVS/pLNRR8=; b=2efvkYqmUODh75sBG/8JCjqee/QE8eM96D5tY/RHcW9xAGdOZCMf12dTZ8Af4bweb3 oI++1kjJ/Mwx9DT+++Yrehnh5CpF+H0xFD++P0ZetSONedhF0Kcfdj39Qmh0YhqWsoiX QkOAY+G4Q1lBTVob+d2r1hBcSTpVQee4IVv7lbF3HYAXPmympnVrFIAzcEx1A5wdthNJ E2w8BdfXM4UcHZBqOX0Af8Dk1d4O9JFvw1wXkiEuZS6ifi56qfyTGufIMssS4PxCMjgn Q4O8xe6s4gA3TrJ8Cn/9yv3nlQ+ifMpQMISwK6h252wAb63r4DY4QAt6tqb3LFLD5jBM 9e9g== X-Gm-Message-State: AJIora+DKCWPI7cXx61RJ/fzOX6L9XZ0Fv1yaykv+I8nA/8GWvsLtTey /vfP2KhmeWWfQCJxpefI4g== X-Google-Smtp-Source: AGRyM1ur4AOc7bK5eVjgml5dO/I1YI3o54vzy9DsjE/7iDAB6CuVvnaI9nMRxVWdksw+oB2ay497Pw== X-Received: by 2002:a92:cd8f:0:b0:2d9:5d44:6a53 with SMTP id r15-20020a92cd8f000000b002d95d446a53mr5817684ilb.226.1656608240763; Thu, 30 Jun 2022 09:57:20 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q25-20020a05663810d900b0032e1a07228asm8851588jad.26.2022.06.30.09.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 09:57:20 -0700 (PDT) Received: (nullmailer pid 2895373 invoked by uid 1000); Thu, 30 Jun 2022 16:57:17 -0000 Date: Thu, 30 Jun 2022 10:57:17 -0600 From: Rob Herring To: Conor Dooley Subject: Re: [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width Message-ID: <20220630165717.GA2895317-robh@kernel.org> References: <20220629184343.3438856-1-mail@conchuod.ie> <20220629184343.3438856-5-mail@conchuod.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220629184343.3438856-5-mail@conchuod.ie> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Niklas Cassel , alsa-devel@alsa-project.org, David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Conor Dooley , Thierry Reding , Krzysztof Kozlowski , linux-riscv@lists.infradead.org, Sam Ravnborg , Masahiro Yamada , Daniel Lezcano , Jose Abreu , Geert Uytterhoeven , Eugeniy Paltsev , devicetree@vger.kernel.org, Albert Ou , Mark Brown , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Dillon Min , Liam Girdwood , Serge Semin , linux-spi@vger.kernel.org, Vinod Koul , Rob Herring , Palmer Dabbelt , dmaengine@vger.kernel.org, Damien Le Moal Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 29 Jun 2022 19:43:33 +0100, Conor Dooley wrote: > From: Conor Dooley > > Most users of dw-apb-ssi use spi-{r,t}x-bus-width of 1, however the > Canaan k210 is wired up for a width of 4. > Quoting Serge: > The modern DW APB SSI controllers of v.4.* and newer also support the > enhanced SPI Modes too (Dual, Quad and Octal). Since the IP-core > version is auto-detected at run-time there is no way to create a > DT-schema correctly constraining the Rx/Tx SPI bus widths. > /endquote > > As such, drop the restriction on only supporting a bus width of 1. > > Link: https://lore.kernel.org/all/20220620205654.g7fyipwytbww5757@mobilestation/ > Signed-off-by: Conor Dooley > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ------ > 1 file changed, 6 deletions(-) > Reviewed-by: Rob Herring