From: Jakub Kicinski <kuba@kernel.org>
To: Guangbin Huang <huangguangbin2@huawei.com>
Cc: <jbrouer@redhat.com>, <hawk@kernel.org>, <brouer@redhat.com>,
<ilias.apalodimas@linaro.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <lorenzo@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bpf@vger.kernel.org>, <lipeng321@huawei.com>,
<chenhao288@hisilicon.com>
Subject: Re: [PATCH net-next v2] net: page_pool: optimize page pool page allocation in NUMA scenario
Date: Thu, 30 Jun 2022 21:15:34 -0700 [thread overview]
Message-ID: <20220630211534.6d1c32da@kernel.org> (raw)
In-Reply-To: <20220629133305.15012-1-huangguangbin2@huawei.com>
On Wed, 29 Jun 2022 21:33:05 +0800 Guangbin Huang wrote:
> +#ifdef CONFIG_NUMA
> + pref_nid = (pool->p.nid == NUMA_NO_NODE) ? numa_mem_id() : pool->p.nid;
> +#else
> + /* Ignore pool->p.nid setting if !CONFIG_NUMA */
> + pref_nid = NUMA_NO_NODE;
> +#endif
Please factor this out to a helper, this is a copy of the code from
page_pool_refill_alloc_cache() and #ifdefs are a little yuck.
next prev parent reply other threads:[~2022-07-01 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 13:33 [PATCH net-next v2] net: page_pool: optimize page pool page allocation in NUMA scenario Guangbin Huang
2022-07-01 4:15 ` Jakub Kicinski [this message]
2022-07-01 7:56 ` Jesper Dangaard Brouer
2022-07-04 1:14 ` wangjie (L)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630211534.6d1c32da@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=huangguangbin2@huawei.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jbrouer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.