From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
imammedo@redhat.com, qemu-devel@nongnu.org
Subject: Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)
Date: Fri, 1 Jul 2022 08:54:54 -0400 [thread overview]
Message-ID: <20220701082552-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAARzgwx4GKLvATe+X+jZQminm1xAM7sgxXeeDQn_KHDozyde+A@mail.gmail.com>
On Fri, Jul 01, 2022 at 03:44:32PM +0530, Ani Sinha wrote:
> but I thought you were suggesting we built bits every time the test is run?
In my opinion 3 scenarios are worth supporting:
- people not touching ACPI, including users - simply don't run the tests,
comparing tables with expected output should be enough
- people making changes indirectly affecting ACPI -
use tests to validate that tables are still well formed,
using a pre built binary should be enough IMO
- people working on ACPI - use tests to analyse the tables,
building from source might be necessary for debugging,
sources change very rarely
- people developing the tests
building from source is required
So I would suggest basically two github repos, one with binaries one with
sources. We'll keep relevant hashes to use in the script.
All in all not that different from submodules but I guess
people have submodules and that is that.
And I personally would probably not tie it to CI whoever owns the
repository can worry about the builds, and I think keeping
things distributed is important.
So
- people not touching ACPI - make check should see directory not found
and skip the test
- people making changes indirectly affecting ACPI -
check out binaries and use
- people working on ACPI -
see that source directory is present, go there
and run make. should not rebuild each time right?
- people developing the tests
building from source is required
--
MST
next prev parent reply other threads:[~2022-07-01 12:56 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 7:28 [PATCH 00/12] Introduce new acpi/smbios qtests using biosbits Ani Sinha
2022-06-27 7:28 ` [PATCH 01/12] qtest: meson.build changes required to integrate python based qtests Ani Sinha
2022-06-27 7:28 ` [PATCH 04/12] acpi/tests/bits: initial commit of test scripts that are run by biosbits Ani Sinha
2022-06-28 7:24 ` Thomas Huth
2022-06-28 9:52 ` Michael S. Tsirkin
2022-06-27 7:28 ` [PATCH 05/12] acpi/tests/bits: disable acpi PSS tests that are failing in biosbits Ani Sinha
2022-06-27 7:28 ` [PATCH 06/12] acpi/tests/bits: add smilatency test suite from bits in order to disable it Ani Sinha
2022-06-27 7:28 ` [PATCH 07/12] acpi/tests/bits: disable smilatency test since it does not pass everytime Ani Sinha
2022-06-27 7:28 ` [PATCH 08/12] acpi/tests/bits: add biosbits config file for running bios tests Ani Sinha
2022-06-27 7:28 ` [PATCH 09/12] acpi/tests/bits: add acpi and smbios python tests that uses biosbits Ani Sinha
2022-06-28 7:20 ` Thomas Huth
2022-06-28 7:26 ` Ani Sinha
2022-06-28 7:36 ` Thomas Huth
2022-06-28 9:55 ` Michael S. Tsirkin
2022-06-28 10:00 ` Thomas Huth
2022-06-27 7:28 ` [PATCH 10/12] acpi/tests/bits: add acpi bits qtest directory in meson for running tests Ani Sinha
2022-06-27 7:28 ` [PATCH 11/12] acpi/tests/bits: add README file for bits qtests Ani Sinha
2022-06-27 22:26 ` Michael S. Tsirkin
2022-06-28 4:57 ` Ani Sinha
2022-06-28 6:06 ` Michael S. Tsirkin
2022-06-28 6:16 ` Ani Sinha
2022-06-28 6:20 ` Michael S. Tsirkin
2022-06-28 6:36 ` Ani Sinha
2022-06-28 6:50 ` Michael S. Tsirkin
2022-06-28 6:57 ` Ani Sinha
2022-06-28 7:03 ` venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests) Thomas Huth
2022-06-28 7:10 ` Michael S. Tsirkin
2022-06-28 7:25 ` Thomas Huth
2022-06-28 7:48 ` Daniel P. Berrangé
2022-06-28 7:51 ` Ani Sinha
2022-06-28 8:23 ` Daniel P. Berrangé
2022-06-28 8:28 ` Thomas Huth
2022-06-28 8:35 ` Ani Sinha
2022-06-28 8:49 ` Ani Sinha
2022-06-28 10:03 ` Michael S. Tsirkin
2022-06-28 10:21 ` Why we should avoid new submodules if possible Thomas Huth
2022-06-28 10:30 ` Michael S. Tsirkin
2022-06-28 10:43 ` Peter Maydell
2022-06-28 11:00 ` Michael S. Tsirkin
2022-06-28 14:54 ` Warner Losh
2022-09-28 20:48 ` Michal Suchánek
2022-09-28 21:07 ` Michael S. Tsirkin
2022-09-28 21:43 ` Michal Suchánek
2022-06-28 10:50 ` Thomas Huth
2022-06-28 11:14 ` Michael S. Tsirkin
2022-06-28 12:39 ` Thomas Huth
2022-06-28 14:45 ` Michael S. Tsirkin
2022-06-28 15:54 ` Ani Sinha
2022-06-28 16:15 ` Daniel P. Berrangé
2022-06-28 18:00 ` Michael S. Tsirkin
2022-06-29 6:28 ` Ani Sinha
2022-07-01 3:34 ` Thomas Huth
2022-07-02 0:05 ` Philippe Mathieu-Daudé via
2022-09-28 9:26 ` Michael S. Tsirkin
2022-09-28 9:33 ` Thomas Huth
2022-09-28 9:47 ` Michael S. Tsirkin
2022-09-28 9:55 ` Thomas Huth
2022-09-28 9:37 ` Daniel P. Berrangé
2022-09-28 9:53 ` Michael S. Tsirkin
2022-09-28 9:57 ` Daniel P. Berrangé
2022-09-28 10:07 ` Michael S. Tsirkin
2022-09-28 13:15 ` Warner Losh
2022-09-28 13:22 ` Michael S. Tsirkin
2022-09-28 10:13 ` Michael S. Tsirkin
2022-09-28 10:18 ` Daniel P. Berrangé
2022-09-28 13:12 ` Michael S. Tsirkin
2022-09-28 15:07 ` Peter Maydell
2022-09-28 19:59 ` Michael S. Tsirkin
2022-09-28 13:06 ` Warner Losh
2022-06-28 10:04 ` venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests) Daniel P. Berrangé
2022-06-28 10:07 ` Michael S. Tsirkin
2022-06-28 10:18 ` Daniel P. Berrangé
2022-06-28 10:25 ` Michael S. Tsirkin
2022-06-28 10:41 ` Ani Sinha
2022-06-28 10:28 ` Ani Sinha
2022-06-28 10:42 ` Daniel P. Berrangé
2022-06-28 11:18 ` Michael S. Tsirkin
2022-06-28 11:28 ` Michael S. Tsirkin
2022-06-28 12:10 ` Peter Maydell
2022-06-28 12:36 ` Ani Sinha
2022-06-28 12:42 ` Thomas Huth
2022-06-28 12:55 ` Daniel P. Berrangé
2022-06-28 13:22 ` Ani Sinha
2022-06-28 13:44 ` Peter Maydell
2022-06-28 13:53 ` Ani Sinha
2022-06-28 13:55 ` Peter Maydell
2022-07-01 4:12 ` Thomas Huth
2022-07-01 6:53 ` Michael S. Tsirkin
2022-07-01 7:28 ` Ani Sinha
2022-07-01 7:38 ` Michael S. Tsirkin
2022-07-01 7:50 ` Ani Sinha
2022-07-01 9:42 ` Michael S. Tsirkin
2022-07-01 10:14 ` Ani Sinha
2022-07-01 12:54 ` Michael S. Tsirkin [this message]
2022-07-04 13:32 ` Ani Sinha
2022-07-05 13:48 ` Ani Sinha
2022-07-07 12:49 ` Ani Sinha
2022-06-28 14:41 ` Michael S. Tsirkin
2022-06-28 14:38 ` Michael S. Tsirkin
2022-06-28 10:14 ` Daniel P. Berrangé
2022-06-28 10:21 ` Michael S. Tsirkin
2022-06-28 10:30 ` Thomas Huth
2022-06-28 10:30 ` Ani Sinha
2022-06-28 10:49 ` Ani Sinha
2022-06-28 10:12 ` Michael S. Tsirkin
2022-06-28 10:16 ` Daniel P. Berrangé
2022-06-28 10:00 ` Michael S. Tsirkin
2022-06-28 7:49 ` Ani Sinha
2022-06-28 7:53 ` Thomas Huth
2022-06-28 9:53 ` Michael S. Tsirkin
2022-06-28 7:05 ` [PATCH 11/12] acpi/tests/bits: add README file for bits qtests Ani Sinha
2022-06-27 7:28 ` [PATCH 12/12] MAINTAINERS: add myself as the maintainer for acpi biosbits qtests Ani Sinha
2022-06-28 8:09 ` [PATCH 00/12] Introduce new acpi/smbios qtests using biosbits Daniel P. Berrangé
2022-06-28 8:33 ` Ani Sinha
2022-06-28 10:06 ` Daniel P. Berrangé
2022-06-28 10:16 ` Michael S. Tsirkin
2022-06-28 10:21 ` Daniel P. Berrangé
2022-06-28 10:35 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701082552-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.