From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org
Subject: Re: [libgpiod v2][PATCH] misc: make gpiod_is_gpiochip_device() not set errno
Date: Fri, 1 Jul 2022 19:43:51 +0800 [thread overview]
Message-ID: <20220701114351.GA41317@sol> (raw)
In-Reply-To: <20220701110056.58502-1-brgl@bgdev.pl>
On Fri, Jul 01, 2022 at 01:00:56PM +0200, Bartosz Golaszewski wrote:
> This function should just report whether the file indicated by path is
> a GPIO chip or not. Let's rework it to not set errno. Failure to open a
> chip should still report errro numbers like before.
>
This is will break my tool patch, for sure.
My gpiodetect uses the errno behaviour to give a clue as to why a chip
might not be available to a user, and that work was already done in
gpiod_is_gpiochip_device().
There might be other places the errno was propagated as well, but
whatever, I'll sort something out.
Cheers,
Kent.
next prev parent reply other threads:[~2022-07-01 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 11:00 [libgpiod v2][PATCH] misc: make gpiod_is_gpiochip_device() not set errno Bartosz Golaszewski
2022-07-01 11:11 ` Andy Shevchenko
2022-07-01 11:43 ` Kent Gibson [this message]
2022-07-01 11:50 ` Bartosz Golaszewski
2022-07-01 11:55 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701114351.GA41317@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.