All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Perez de Castro <aperez@igalia.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select audiofx for multimedia
Date: Fri, 1 Jul 2022 13:33:22 +0200	[thread overview]
Message-ID: <20220701133322.GD636837@momiji> (raw)
In-Reply-To: <20220627072336.2673298-1-james.hilliard1@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2160 bytes --]

On Mon, 27 Jun 2022 01:23:36 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> When using webkit with multimedia support the scaletempo element may
> be needed, select the audiofx plugin which provides scaletempo.
> 
> Fixes runtime warning:
> createGSTPlayBin: Failed to create scaletempo
> 
> See:
> https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L2813
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Acked-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/webkitgtk/Config.in | 1 +
>  package/wpewebkit/Config.in | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> index 2575108363..d0c73f3f29 100644
> --- a/package/webkitgtk/Config.in
> +++ b/package/webkitgtk/Config.in
> @@ -107,6 +107,7 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUDIOFX
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUTODETECT
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ISOMP4
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> index f50e0da21c..a205e6276f 100644
> --- a/package/wpewebkit/Config.in
> +++ b/package/wpewebkit/Config.in
> @@ -100,6 +100,7 @@ config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUDIOFX
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUTODETECT
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ISOMP4
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-01 11:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27  7:23 [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select audiofx for multimedia James Hilliard
2022-07-01 11:33 ` Adrian Perez de Castro [this message]
2022-07-20 21:23 ` Thomas Petazzoni via buildroot
2022-08-11 17:31 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220701133322.GD636837@momiji \
    --to=aperez@igalia.com \
    --cc=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.